PB-366: Templates Lower Level Test Coverage

Author: davemacaulay

app/code/Magento/PageBuilder/Controller/Adminhtml/Template/Delete.php

@@ -10,7 +10,7 @@
 
 use Magento\Backend\App\Action;
 use Magento\Backend\App\Action\Context;
-use Magento\Framework\App\Action\HttpGetActionInterface;
+use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\PageBuilder\Api\Data\TemplateInterface;
 use Magento\PageBuilder\Api\TemplateRepositoryInterface;
@@ -20,7 +20,7 @@
 /**
  * Delete a template within template manager
  */
-class Delete extends Action implements HttpGetActionInterface
+class Delete extends Action implements HttpPostActionInterface
 {
     const ADMIN_RESOURCE = 'Magento_PageBuilder::template_delete';
 

app/code/Magento/PageBuilder/Ui/Component/Listing/Columns/TemplateManagerActions.php

@@ -8,13 +8,13 @@
 
 namespace Magento\PageBuilder\Ui\Component\Listing\Columns;
 
+use Magento\Framework\AuthorizationInterface;
 use Magento\Framework\Escaper;
 use Magento\Framework\UrlInterface;
 use Magento\Framework\View\Element\UiComponent\ContextInterface;
 use Magento\Framework\View\Element\UiComponentFactory;
-use Magento\Ui\Component\Listing\Columns\Column;
-use Magento\Framework\AuthorizationInterface;
 use Magento\PageBuilder\Model\Stage\Config;
+use Magento\Ui\Component\Listing\Columns\Column;
 
 /**
  * Provide actions to the action column in Templates grid
@@ -78,7 +78,6 @@ public function prepare()
      */
     public function prepareDataSource(array $dataSource)
     {
-
         if (isset($dataSource['data']['items'])) {
             foreach ($dataSource['data']['items'] as & $item) {
                 $name = $this->getData('name');
@@ -96,10 +95,10 @@ public function prepareDataSource(array $dataSource)
                             ),
                             'confirm' => [
                                 'title' => __('Delete %1?', $templateName),
-                                'message' =>
-                                    __('Are you sure you want to permanently delete template %1?', $templateName),
+                                'message' => __('Are you sure you want to permanently delete template %1?', $templateName),
                                 '__disableTmpl' => true,
                             ],
+                            'post' => true,
                             '__disableTmpl' => true,
                         ];
                     }

dev/tests/integration/testsuite/Magento/PageBuilder/Controller/Adminhtml/Template/DeleteTest.php

@@ -70,7 +70,7 @@ public function testDeleteAction()
         $items = $findTemplate->getItems();
         $templateId = reset($items)->getId();
 
-        $this->getRequest()->setPostValue(['template_id' => $templateId])->setMethod(HttpRequest::METHOD_GET);
+        $this->getRequest()->setPostValue(['template_id' => $templateId])->setMethod(HttpRequest::METHOD_POST);
         $this->deleteController->execute();
 
         $this->expectExceptionMessage('Template with id "' . $templateId . '" does not exist.');