Skip to content

Commit c918f76

Browse files
committed
PB-366: Templates Lower Level Test Coverage
1 parent efb23b7 commit c918f76

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

app/code/Magento/PageBuilder/Model/TemplateRepository.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,8 @@ public function getList(SearchCriteriaInterface $criteria)
121121

122122
$searchResults = $this->searchResultsFactory->create();
123123
$searchResults->setSearchCriteria($criteria);
124-
125-
$items = [];
126-
foreach ($collection as $model) {
127-
$items[] = $model;
128-
}
129-
130-
$searchResults->setItems($items);
124+
$searchResults->setItems($collection->getItems());
131125
$searchResults->setTotalCount($collection->getSize());
132-
133126
return $searchResults;
134127
}
135128

dev/tests/integration/testsuite/Magento/PageBuilder/Controller/Adminhtml/Template/DeleteTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ public function testDeleteAction()
6767
$this->searchCriteriaBuilder->addFilter('name', 'Test Template')->create()
6868
);
6969
$this->assertEquals(1, $findTemplate->getTotalCount());
70-
$templateId = $findTemplate->getItems()[0]->getId();
70+
$items = $findTemplate->getItems();
71+
$templateId = reset($items)->getId();
7172

7273
$this->getRequest()->setPostValue(['template_id' => $templateId])->setMethod(HttpRequest::METHOD_GET);
7374
$this->deleteController->execute();

0 commit comments

Comments
 (0)