Skip to content

Commit f505491

Browse files
committed
MC-4129: Edit Panel Opens After Dragging & Dropping Content Types
- Resolve functional test failures
1 parent ae15c76 commit f505491

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
<group value="pagebuilder-slide"/>
2222
<group value="pagebuilder-slideItemCollageCenter"/>
2323
</annotations>
24-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
24+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
2525
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
2626
</actionGroup>
27-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
2827
</test>
2928
<test name="SlideItemCollageCenterWYSIWYGDisabledInlineEdit" extends="SlideItemPosterCanInlineEditContent">
3029
<annotations>
@@ -47,10 +46,9 @@
4746
<after>
4847
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
4948
</after>
50-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
49+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
5150
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
5251
</actionGroup>
53-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
5452
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
5553
<argument name="contentType" value="PageBuilderSliderContentType"/>
5654
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
@@ -86,10 +84,9 @@
8684
<after>
8785
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4" before="logout"/>
8886
</after>
89-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
87+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
9088
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
9189
</actionGroup>
92-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
9390
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
9491
<argument name="contentType" value="PageBuilderSliderContentType"/>
9592
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
<group value="pagebuilder-slide"/>
2222
<group value="pagebuilder-slideItemCollageLeft"/>
2323
</annotations>
24-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
24+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
2525
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
2626
</actionGroup>
27-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
2827
</test>
2928
<test name="SlideItemCollageLeftWYSIWYGDisabledInlineEdit" extends="SlideItemPosterCanInlineEditContent">
3029
<annotations>
@@ -47,10 +46,9 @@
4746
<after>
4847
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
4948
</after>
50-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
49+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
5150
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
5251
</actionGroup>
53-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
5452
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
5553
<argument name="contentType" value="PageBuilderSliderContentType"/>
5654
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
@@ -86,10 +84,9 @@
8684
<after>
8785
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4" before="logout"/>
8886
</after>
89-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
87+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
9088
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
9189
</actionGroup>
92-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
9390
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
9491
<argument name="contentType" value="PageBuilderSliderContentType"/>
9592
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
<group value="pagebuilder-slide"/>
2222
<group value="pagebuilder-slideItemCollageRight"/>
2323
</annotations>
24-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
24+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
2525
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
2626
</actionGroup>
27-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
2827
</test>
2928
<test name="SlideItemCollageRightWYSIWYGDisabledInlineEdit" extends="SlideItemPosterCanInlineEditContent">
3029
<annotations>
@@ -47,10 +46,9 @@
4746
<after>
4847
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
4948
</after>
50-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
49+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
5150
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
5251
</actionGroup>
53-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
5452
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
5553
<argument name="contentType" value="PageBuilderSliderContentType"/>
5654
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
@@ -86,10 +84,9 @@
8684
<after>
8785
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4" before="logout"/>
8886
</after>
89-
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
87+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
9088
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
9189
</actionGroup>
92-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
9390
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
9491
<argument name="contentType" value="PageBuilderSliderContentType"/>
9592
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>

0 commit comments

Comments
 (0)