Skip to content

Commit ae15c76

Browse files
committed
MC-4129: Edit Panel Opens After Dragging & Dropping Content Types
Address additional CR feedback
1 parent f81ebd2 commit ae15c76

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,10 @@
4545
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="dragSliderIntoStage">
4646
<argument name="section" value="SlideOnBackend"/>
4747
</actionGroup>
48-
<!-- Extended tests modify configuration of slider here -->
49-
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
48+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
49+
<argument name="property" value="PageBuilderAppearance_Poster"/>
50+
</actionGroup>
51+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
5052
<!-- Inline Edit Slide Content -->
5153
<comment userInput="Inline Edit Slide Content" stepKey="commentInlineEdit"/>
5254
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -696,6 +696,7 @@
696696
<argument name="contentType" value="PageBuilderSliderContentType"/>
697697
</actionGroup>
698698
<click selector="{{SlideOnBackend.openOptionsMenu('1')}}" stepKey="openSlideOptionsMenu"/>
699+
<waitForPageLoad stepKey="waitForPageLoadAfterClickingOptionsMenuForSlide" />
699700
<waitForElementNotVisible selector="{{PageBuilderContentTypeOptionsMenu.contentTypeHide(PageBuilderSlideContentType.role, '1')}}" stepKey="waitForHideOptionNotVisible" />
700701
<dontSeeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeHide(PageBuilderSlideContentType.role, '1')}}" stepKey="dontSeeHideOption" />
701702
</test>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1491,8 +1491,9 @@
14911491
<!-- Validate Slide 2 Is Shown -->
14921492
<comment userInput="Validate Slide 2 Is Shown" stepKey="commentValidateStage2"/>
14931493
<seeElement selector="{{SliderOnStage.slideNavigationDot('1', '2')}}" stepKey="seeSecondDot"/>
1494-
<waitForPageLoad stepKey="waitForPageLoadAfterClickingSlideNavigationDot2" />
1494+
<waitForPageLoad stepKey="waitForPageLoadAfterSeeingSlideNavigationDot2" />
14951495
<click selector="{{SliderOnStage.slideNavigationDot('1', '2')}}" stepKey="clickSlide2OptionsMenu"/>
1496+
<waitForPageLoad stepKey="waitForPageLoadAfterClickingSlideNavigationDot2" />
14961497
<seeElement selector="{{SlideOnBackend.optionsMenu('2')}}" stepKey="seeSlideOptionsMenu4"/>
14971498
<assertElementContainsAttribute selector="{{SliderOnStage.slideNavigationDot('1', '2')}}" attribute="class" stepKey="assertSecondDotActive">
14981499
<expectedResult type="string">active</expectedResult>

0 commit comments

Comments
 (0)