Skip to content

Commit e8b7d86

Browse files
committed
MC-4265: update composer.json for magento/module-page-builder-analytics
- address code review feedback
1 parent 6455020 commit e8b7d86

File tree

2 files changed

+4
-11
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+4
-11
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ export default class Preview extends BasePreview {
3838
*/
3939
private element: HTMLElement;
4040

41-
/**
42-
* Uploader instance
43-
*/
44-
private uploader: Uploader;
45-
4641
/**
4742
* Slide flag
4843
*/
@@ -140,18 +135,17 @@ export default class Preview extends BasePreview {
140135
* @returns {Uploader}
141136
*/
142137
public getUploader() {
143-
const dataStore = this.parent.dataStore.get() as any[];
138+
const dataStore = this.parent.dataStore.get();
144139
const initialImageValue = dataStore[this.config.additional_data.uploaderConfig.dataScope] || "";
145140

146141
// Create uploader
147-
this.uploader = new Uploader(
142+
return new Uploader(
148143
"imageuploader_" + this.parent.id,
149144
this.config.additional_data.uploaderConfig,
150145
this.parent.id,
151146
this.parent.dataStore,
152147
initialImageValue,
153148
);
154-
return this.uploader;
155149
}
156150

157151
/**

0 commit comments

Comments
 (0)