Skip to content

Commit 6455020

Browse files
committed
MC-4265: update composer.json for magento/module-page-builder-analytics
- address code review feedback
1 parent fc5e1ad commit 6455020

File tree

11 files changed

+23
-196
lines changed

11 files changed

+23
-196
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/banner/converter/style/preview/display.js

Lines changed: 0 additions & 41 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/banner/preview.js

Lines changed: 1 addition & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/buttons/converter/style/display.js

Lines changed: 0 additions & 51 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/image/preview.js

Lines changed: 1 addition & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/form/provider.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 6 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/text/preview.js

Lines changed: 1 addition & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/text/wysiwyg/tinymce4/config-initializer.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/adminhtml/web/js/property/link.js

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,17 @@ export default class Preview extends BasePreview {
140140
* @returns {Uploader}
141141
*/
142142
public getUploader() {
143+
const dataStore = this.parent.dataStore.get() as any[];
144+
const initialImageValue = dataStore[this.config.additional_data.uploaderConfig.dataScope] || "";
145+
146+
// Create uploader
147+
this.uploader = new Uploader(
148+
"imageuploader_" + this.parent.id,
149+
this.config.additional_data.uploaderConfig,
150+
this.parent.id,
151+
this.parent.dataStore,
152+
initialImageValue,
153+
);
143154
return this.uploader;
144155
}
145156

@@ -251,18 +262,6 @@ export default class Preview extends BasePreview {
251262

252263
events.on(`${this.config.name}:mountAfter`, (args: ContentTypeMountEventParamsInterface) => {
253264
if (args.id === this.parent.id) {
254-
const dataStore = this.parent.dataStore.get();
255-
const initialImageValue = dataStore[this.config.additional_data.uploaderConfig.dataScope] || "";
256-
257-
// Create uploader
258-
this.uploader = new Uploader(
259-
"imageuploader_" + this.parent.id,
260-
this.config.additional_data.uploaderConfig,
261-
this.parent.id,
262-
this.parent.dataStore,
263-
initialImageValue,
264-
);
265-
266265
// Update the display label for the slide
267266
const slider = this.parent.parent;
268267
this.displayLabel($t(`Slide ${slider.children().indexOf(this.parent) + 1}`));

0 commit comments

Comments
 (0)