Skip to content

Commit e2c6f48

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Fix issue when args.element is undefined
1 parent c5a8238 commit e2c6f48

File tree

2 files changed

+8
-4
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+8
-4
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,10 @@ export default class Preview extends PreviewCollection {
8080

8181
// Redraw slide after content type gets redrawn
8282
events.on("contentType:redrawAfter", function(args: ContentTypeAfterRenderEventParamsInterface) {
83-
if ($.contains(args.element, this.element)) {
84-
$(this.element).slick("setPosition");
83+
const $element = $(this.element);
84+
85+
if ($element.closest(args.element).length) {
86+
$element.slick("setPosition");
8587
}
8688
}.bind(this));
8789

0 commit comments

Comments
 (0)