Skip to content

Commit c5a8238

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Rebuild slick only if it's been deemed ready from a previous build
1 parent aa85a09 commit c5a8238

File tree

2 files changed

+13
-2
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+13
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,14 @@ export default class Preview extends PreviewCollection {
173173
*/
174174
public afterChildrenRender(element: HTMLElement): void {
175175
this.element = element;
176-
this.buildSlick();
176+
177+
const isARerenderingOfSlider = this.ready;
178+
179+
// if slider has been re-rendered previously on this element, re-build
180+
if (isARerenderingOfSlider) {
181+
this.buildSlick();
182+
}
183+
177184
super.afterChildrenRender(element);
178185
this.afterChildrenRenderDeferred.resolve(element);
179186
}

0 commit comments

Comments
 (0)