Skip to content

Commit dbfb3dc

Browse files
PB-277: Full height Row
- fix tests
1 parent 7abcd68 commit dbfb3dc

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,9 @@
187187
<group value="pagebuilder"/>
188188
<group value="pagebuilder-column"/>
189189
</annotations>
190+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
191+
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
192+
</actionGroup>
190193
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
191194
<argument name="contentType" value="PageBuilderColumnContentType"/>
192195
</actionGroup>
@@ -222,6 +225,9 @@
222225
<group value="pagebuilder"/>
223226
<group value="pagebuilder-column"/>
224227
</annotations>
228+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
229+
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
230+
</actionGroup>
225231
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
226232
<argument name="contentType" value="PageBuilderColumnContentType"/>
227233
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowLayoutTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@
474474
<argument name="contentTypeIndex" value="2"/>
475475
</actionGroup>
476476
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightPropertySecondRow">
477-
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
477+
<argument name="property" value="PageBuilderMinHeightProperty_300px"/>
478478
</actionGroup>
479479
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentCenterProperty">
480480
<argument name="property" value="PageBuilderVerticalAlignmentPropertyCenter"/>
@@ -498,7 +498,7 @@
498498
<argument name="contentTypeIndex" value="3"/>
499499
</actionGroup>
500500
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightPropertyThirdRow">
501-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
501+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
502502
</actionGroup>
503503
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentBottomProperty">
504504
<argument name="property" value="PageBuilderVerticalAlignmentPropertyBottom"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@
982982
<argument name="property" value="PageBuilderRowParallaxSpeed_2"/>
983983
</actionGroup>
984984
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="validateMinHeight">
985-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
985+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
986986
</actionGroup>
987987
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateVerticalAlignContent">
988988
<argument name="property" value="PageBuilderVerticalAlignmentPropertyCenter"/>
@@ -1092,7 +1092,7 @@
10921092
<argument name="property" value="PageBuilderRowParallaxSpeed_2"/>
10931093
</actionGroup>
10941094
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="validateMinHeight2">
1095-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
1095+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
10961096
</actionGroup>
10971097
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateVerticalAlignContent2">
10981098
<argument name="property" value="PageBuilderVerticalAlignmentPropertyCenter"/>
@@ -1149,7 +1149,7 @@
11491149
<actionGroup ref="validateLayoutStylesWithAllUpdated" stepKey="validateAllLayoutStorefront">
11501150
<argument name="page" value="RowOnStorefront_FullWidth_FullBleed"/>
11511151
<argument name="index" value="2"/>
1152-
<argument name="minHeight" value="PageBuilderMinHeightProperty_500"/>
1152+
<argument name="minHeight" value="PageBuilderMinHeightProperty_500px"/>
11531153
<argument name="verticalAlignContainer" value="PageBuilderVerticalAlignmentPropertyCenter"/>
11541154
</actionGroup>
11551155
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStorefront">
@@ -1981,20 +1981,20 @@
19811981
<!-- Get value of assigned min height on element -->
19821982
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="assignedHeight" />
19831983
<assertEquals stepKey="assertEqualToEnteredValue">
1984-
<expectedResult type="string">{{PageBuilderMinHeightProperty_300.value}}</expectedResult>
1984+
<expectedResult type="string">{{PageBuilderMinHeightProperty_300px.value}}</expectedResult>
19851985
<actualResult type="variable">$assignedHeight</actualResult>
19861986
</assertEquals>
19871987
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
19881988
<argument name="contentType" value="PageBuilderRowContentType"/>
19891989
</actionGroup>
19901990
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinimumHeightProperty2">
1991-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
1991+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
19921992
</actionGroup>
19931993
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings4"/>
19941994
<!-- Get value of assigned min height on element -->
19951995
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="assignedHeight2" />
19961996
<assertEquals stepKey="assertEqualToEnteredValue2">
1997-
<expectedResult type="string">{{PageBuilderMinHeightProperty_500.value}}</expectedResult>
1997+
<expectedResult type="string">{{PageBuilderMinHeightProperty_500px.value}}</expectedResult>
19981998
<actualResult type="variable">$assignedHeight2</actualResult>
19991999
</assertEquals>
20002000
</test>

0 commit comments

Comments
 (0)