Skip to content

Commit 7abcd68

Browse files
PB-277: Full height Row
- fix tests
1 parent 15ce5be commit 7abcd68

File tree

4 files changed

+29
-7
lines changed

4 files changed

+29
-7
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,48 @@
2929
<data key="value">500</data>
3030
<data key="style">min-height: 500px</data>
3131
</entity>
32+
<entity name="PageBuilderMinHeightProperty_500px" type="pagebuilder_min_height_property">
33+
<data key="name">Minimum Height</data>
34+
<data key="section">appearance_fieldset</data>
35+
<data key="fieldName">min_height</data>
36+
<data key="value">500px</data>
37+
<data key="style">min-height: 500px</data>
38+
</entity>
3239
<entity name="PageBuilderMinHeightProperty_300" type="pagebuilder_min_height_property">
3340
<data key="name">Minimum Height</data>
3441
<data key="section">appearance_fieldset</data>
3542
<data key="fieldName">min_height</data>
3643
<data key="value">300</data>
3744
<data key="style">min-height: 300px</data>
3845
</entity>
46+
<entity name="PageBuilderMinHeightProperty_300px" type="pagebuilder_min_height_property">
47+
<data key="name">Minimum Height</data>
48+
<data key="section">appearance_fieldset</data>
49+
<data key="fieldName">min_height</data>
50+
<data key="value">300px</data>
51+
<data key="style">min-height: 300px</data>
52+
</entity>
3953
<entity name="PageBuilderMinHeightProperty_200" type="pagebuilder_min_height_property">
4054
<data key="name">Minimum Height</data>
4155
<data key="section">appearance_fieldset</data>
4256
<data key="fieldName">min_height</data>
4357
<data key="value">200</data>
4458
<data key="style">min-height: 200px</data>
4559
</entity>
60+
<entity name="PageBuilderMinHeightProperty_200px" type="pagebuilder_min_height_property">
61+
<data key="name">Minimum Height</data>
62+
<data key="section">appearance_fieldset</data>
63+
<data key="fieldName">min_height</data>
64+
<data key="value">200px</data>
65+
<data key="style">min-height: 200px</data>
66+
</entity>
4667
<entity name="PageBuilderMinHeightProperty_NonNumeric" type="pagebuilder_min_height_property">
4768
<data key="name">Minimum Height</data>
4869
<data key="section">appearance_fieldset</data>
4970
<data key="fieldName">min_height</data>
5071
<data key="value">a</data>
5172
<data key="errorMessage">Please enter a valid number in this field.</data>
73+
<!-- TODO: update message-->
5274
</entity>
5375
<entity name="PageBuilderMinHeightProperty_Negative1" type="pagebuilder_min_height_property">
5476
<data key="name">Minimum Height</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<argument name="contentType" value="PageBuilderRowContentType"/>
4040
</actionGroup>
4141
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
42-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
42+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
4343
</actionGroup>
4444
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentBottomProperty">
4545
<argument name="property" value="PageBuilderVerticalAlignmentPropertyBottom"/>
@@ -361,7 +361,7 @@
361361
<argument name="property" value="PageBuilderRowParallaxSpeed_2"/>
362362
</actionGroup>
363363
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
364-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
364+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
365365
</actionGroup>
366366
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentCenterProperty">
367367
<argument name="property" value="PageBuilderVerticalAlignmentPropertyCenter"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowLayoutTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
<argument name="contentType" value="PageBuilderRowContentType"/>
180180
</actionGroup>
181181
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
182-
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
182+
<argument name="property" value="PageBuilderMinHeightProperty_300px"/>
183183
</actionGroup>
184184
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBorder">
185185
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
@@ -249,7 +249,7 @@
249249
<argument name="contentType" value="PageBuilderRowContentType"/>
250250
</actionGroup>
251251
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
252-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
252+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
253253
</actionGroup>
254254
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBorder">
255255
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
@@ -448,7 +448,7 @@
448448
<argument name="contentTypeIndex" value="1"/>
449449
</actionGroup>
450450
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightPropertyFirstRow">
451-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
451+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
452452
</actionGroup>
453453
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentTopProperty">
454454
<argument name="property" value="PageBuilderVerticalAlignmentPropertyTop"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,7 @@
853853
<argument name="property" value="PageBuilderRowParallaxSpeed_2"/>
854854
</actionGroup>
855855
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
856-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
856+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
857857
</actionGroup>
858858
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentCenterProperty">
859859
<argument name="property" value="PageBuilderVerticalAlignmentPropertyCenter"/>
@@ -1975,7 +1975,7 @@
19751975
<argument name="property" value="PageBuilderRowParallax_Enabled"/>
19761976
</actionGroup>
19771977
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinimumHeightProperty">
1978-
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
1978+
<argument name="property" value="PageBuilderMinHeightProperty_300px"/>
19791979
</actionGroup>
19801980
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
19811981
<!-- Get value of assigned min height on element -->

0 commit comments

Comments
 (0)