MC-3363: Additional configuration node changes

- Fixed documentation
- Removed uneeded if statement
- Updated config.php to use null coalesce

Author: Michael Yu

app/code/Magento/PageBuilder/Model/Config/Group/Converter.php

@@ -33,15 +33,12 @@ public function convert($source): array
     private function convertGroups(\DOMDocument $source): array
     {
         $groupsData = [];
-        /** @var \DOMNode $source */
         /** @var \DOMNode $group */
         foreach ($source->getElementsByTagName('group') as $group) {
-            if ($group->nodeType == XML_ELEMENT_NODE && $group->tagName == 'group') {
-                $name = $group->attributes->getNamedItem('name')->nodeValue;
-                /** @var \DOMElement $attributeValue */
-                foreach ($group->attributes as $attributeName => $attributeValue) {
-                    $groupsData[$name][$attributeName] = $attributeValue->nodeValue;
-                }
+            $name = $group->attributes->getNamedItem('name')->nodeValue;
+            /** @var \DOMElement $attributeValue */
+            foreach ($group->attributes as $attributeName => $attributeValue) {
+                $groupsData[$name][$attributeName] = $attributeValue->nodeValue;
             }
         }
         uasort($groupsData, function ($firstElement, $secondElement) {

app/code/Magento/PageBuilder/Model/Stage/Config.php

@@ -152,28 +152,21 @@ private function flattenContentTypeData($name, $contentType)
             'icon' => $contentType['icon'],
             'form' => $contentType['form'],
             'contentType' => '',
-            'group' => (isset($contentType['group'])
-                ? $contentType['group'] : 'general'),
-            'fields' => $this->uiComponentConfig->getFields($contentType['form']),
-            'preview_template' => (isset($contentType['preview_template'])
-                ? $contentType['preview_template'] : ''),
-            'render_template' => (isset($contentType['render_template'])
-                ? $contentType['render_template'] : ''),
+            'group' => $contentType['group'] ?? 'general',
+            'fields' => $this->uiComponentConfig->getFields($contentType['form'],
+            'preview_template' => $contentType['preview_template'] ?? '',
+            'render_template' => $contentType['render_template'] ?? '',
             'component' => $contentType['component'],
-            'preview_component' => (isset($contentType['preview_component'])
-                ? $contentType['preview_component']
-                : self::DEFAULT_PREVIEW_COMPONENT),
-            'master_component' => (isset($contentType['master_component'])
-                ? $contentType['master_component']
-                : self::DEFAULT_MASTER_COMPONENT),
-            'allowed_parents' => isset($contentType['allowed_parents']) ? $contentType['allowed_parents'] : [],
-            'readers' => isset($contentType['readers']) ? $contentType['readers'] : [],
-            'appearances' => isset($contentType['appearances']) ? $contentType['appearances'] : [],
+            'preview_component' => $contentType['preview_component'] ?? self::DEFAULT_PREVIEW_COMPONENT,
+            'master_component' => $contentType['master_component'] ?? self::DEFAULT_MASTER_COMPONENT,
+            'allowed_parents' => $contentType['allowed_parents'] ?? [],
+            'readers' => $contentType['readers'] ?? [],
+            'appearances' => $contentType['appearances'] ?? [],
             'additional_data' => isset($contentType['additional_data'])
                 ? $this->additionalDataParser->toArray($contentType['additional_data'])
                 : [],
-            'elements' => isset($contentType['elements']) ? $contentType['elements'] : [],
-            'converters' => isset($contentType['converters']) ? $contentType['converters'] : [],
+            'elements' => $contentType['elements'] ?? [],
+            'converters' => $contentType['converters'] ?? [],
             'is_visible' => isset($contentType['is_visible']) && $contentType['is_visible'] === 'false' ? false : true
         ];
     }