Skip to content

Commit 5b3f99e

Browse files
author
Michael Yu
committed
MC-3363: Additional configuration node changes
- Resolved static test failure - Resolved failed expected integration test results
1 parent 9f66551 commit 5b3f99e

File tree

2 files changed

+20
-19
lines changed

2 files changed

+20
-19
lines changed

dev/tests/integration/testsuite/Magento/PageBuilder/_files/content_type/expected_merged_array.php

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,25 @@
44
* See COPYING.txt for license details.
55
*/
66
return [
7-
'group1' => [
8-
'label' => 'Group 1',
9-
'sortOrder' => '1',
10-
'name' => 'group1',
11-
'translate' => 'label'
12-
],
13-
'group2' => [
14-
'label' => 'Group 2 Label',
15-
'sortOrder' => '3',
16-
'name' => 'group2',
17-
'translate' => 'label'
18-
],
19-
'group3' => [
20-
'label' => 'Group 3 Label',
21-
'sortOrder' => '2',
22-
'name' => 'group3',
23-
'translate' => 'label'
7+
'groups' => [
8+
'group1' => [
9+
'label' => 'Group 1',
10+
'sortOrder' => '1',
11+
'name' => 'group1',
12+
'translate' => 'label'
13+
],
14+
'group2' => [
15+
'label' => 'Group 2 Label',
16+
'sortOrder' => '3',
17+
'name' => 'group2',
18+
'translate' => 'label'
19+
],
20+
'group3' => [
21+
'label' => 'Group 3 Label',
22+
'sortOrder' => '2',
23+
'name' => 'group3',
24+
'translate' => 'label'
25+
]
2426
],
2527
'types' => [
2628
'type1' => [

dev/tests/static/testsuite/Magento/Test/Integrity/Xml/GroupsTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ private function getContentTypeGroups(): array
9191
foreach ($files as $filename) {
9292
$dom = new \DOMDocument();
9393
$dom->loadXML(file_get_contents($filename));
94-
$groups = $dom->getElementsByTagName('group');
95-
foreach ($groups->childNodes as $group) {
94+
foreach ($dom->getElementsByTagName('group') as $group) {
9695
if ($group->nodeType == XML_ELEMENT_NODE && $group->tagName == 'group') {
9796
$data[] = $group->attributes->getNamedItem('name')->nodeValue;
9897
}

0 commit comments

Comments
 (0)