Skip to content

Commit b3b75ad

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Assign this.element before (re-)building slick
1 parent 625968f commit b3b75ad

File tree

2 files changed

+12
-2
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+12
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,8 @@ export default class Preview extends PreviewCollection {
172172
* @param {HTMLElement} element
173173
*/
174174
public afterChildrenRender(element: HTMLElement): void {
175+
this.element = element;
176+
this.buildSlick();
175177
super.afterChildrenRender(element);
176178
this.afterChildrenRenderDeferred.resolve(element);
177179
}
@@ -359,7 +361,9 @@ export default class Preview extends PreviewCollection {
359361
}
360362

361363
// Dispose current subscription in order to prevent infinite loop
362-
this.childSubscribe.dispose();
364+
if (this.childSubscribe) {
365+
this.childSubscribe.dispose();
366+
}
363367

364368
// Force an update on all children, ko tries to intelligently re-render but fails
365369
const data = this.parent.children().slice(0);

0 commit comments

Comments
 (0)