Skip to content

Commit 625968f

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Fix transportability of tabs
1 parent 5da3bf7 commit 625968f

File tree

2 files changed

+10
-4
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+10
-4
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/preview.js

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export default class Preview extends PreviewCollection {
143143
* @param {number} activeIndex
144144
*/
145145
public refreshTabs(focusIndex?: number, forceFocus?: boolean, activeIndex?: number) {
146-
if (this.ready) {
146+
try {
147147
$(this.element).tabs("refresh");
148148
if (focusIndex >= 0) {
149149
this.setFocusedTab(focusIndex, forceFocus);
@@ -159,6 +159,8 @@ export default class Preview extends PreviewCollection {
159159
sortableElement.sortable("enable");
160160
}
161161
}
162+
} catch (e) {
163+
this.buildTabs();
162164
}
163165
}
164166

@@ -255,6 +257,7 @@ export default class Preview extends PreviewCollection {
255257
* @param {Element} element
256258
*/
257259
public onContainerRender(element: Element) {
260+
this.element = element;
258261
this.onContainerRenderDeferred.resolve(element);
259262
}
260263

@@ -487,7 +490,7 @@ export default class Preview extends PreviewCollection {
487490
}
488491
}
489492

490-
// Resolve issue with jQuery UI tabs content typeing events on content editable areas
493+
// Resolve issue with jQuery UI tabs content typing events on content editable areas
491494
const originalTabKeyDown = $.ui.tabs.prototype._tabKeydown;
492495
$.ui.tabs.prototype._tabKeydown = function(event: Event) {
493496
// If the target is content editable don't handle any events

0 commit comments

Comments
 (0)