Skip to content

Commit a5ff82b

Browse files
omiroshnichenkoomiroshnichenko
committed
PB-378: Full height Banner
- fix test - revert default min height value
1 parent e7e10f6 commit a5ff82b

9 files changed

+32
-15
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,24 @@
4646
<data key="fieldName">min_height</data>
4747
<data key="value">500</data>
4848
</entity>
49+
<entity name="PageBuilderBannerMinimumHeightPxProperty" type="pagebuilder_banner_minimumHeight_property">
50+
<data key="name">Minimum Height</data>
51+
<data key="section">appearance_fieldset</data>
52+
<data key="fieldName">min_height</data>
53+
<data key="value">500px</data>
54+
</entity>
4955
<entity name="PageBuilderBannerMinimumHeightDefaultProperty" type="pagebuilder_banner_minimumHeightDefault_property">
5056
<data key="name">Minimum Height</data>
5157
<data key="section">appearance_fieldset</data>
5258
<data key="fieldName">min_height</data>
5359
<data key="value">300</data>
5460
</entity>
61+
<entity name="PageBuilderBannerMinimumHeightDefaultPxProperty" type="pagebuilder_banner_minimumHeightDefault_property">
62+
<data key="name">Minimum Height</data>
63+
<data key="section">appearance_fieldset</data>
64+
<data key="fieldName">min_height</data>
65+
<data key="value">300px</data>
66+
</entity>
5567
<!-- Message Text -->
5668
<entity name="PageBuilderBannerMessageDefaultProperty" type="pagebuilder_banner_message_property">
5769
<data key="name">Message Text</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@
888888
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
889889
</actionGroup>
890890
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
891-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
891+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
892892
</actionGroup>
893893
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
894894
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>
@@ -1032,7 +1032,7 @@
10321032
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
10331033
</actionGroup>
10341034
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeMinimumHeight">
1035-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1035+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
10361036
</actionGroup>
10371037
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeBackgroundColor">
10381038
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -919,7 +919,7 @@
919919
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
920920
</actionGroup>
921921
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
922-
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultProperty"/>
922+
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultPxProperty"/>
923923
</actionGroup>
924924
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
925925
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
@@ -987,7 +987,7 @@
987987
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
988988
</actionGroup>
989989
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
990-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
990+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
991991
</actionGroup>
992992
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
993993
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>
@@ -1131,7 +1131,7 @@
11311131
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
11321132
</actionGroup>
11331133
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeMinimumHeight">
1134-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1134+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
11351135
</actionGroup>
11361136
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeBackgroundColor">
11371137
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@
888888
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
889889
</actionGroup>
890890
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
891-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
891+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
892892
</actionGroup>
893893
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
894894
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>
@@ -1032,7 +1032,7 @@
10321032
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
10331033
</actionGroup>
10341034
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeMinimumHeight">
1035-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1035+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
10361036
</actionGroup>
10371037
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeBackgroundColor">
10381038
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@
353353
<argument name="property4" value="PageBuilderBannerCollageCenteredProperty"/>
354354
</actionGroup>
355355
<actionGroup ref="validateSlideOutPanelField" stepKey="seeMinimumHeightProperty">
356-
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultProperty"/>
356+
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultPxProperty"/>
357357
</actionGroup>
358358
<actionGroup ref="validateSlideOutPanelField" stepKey="seeBackgroundColorProperty">
359359
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>
@@ -1474,7 +1474,7 @@
14741474
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
14751475
</actionGroup>
14761476
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
1477-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1477+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
14781478
</actionGroup>
14791479
<!-- Update Background Section -->
14801480
<comment userInput="Update Background Section" stepKey="commentUpdateBackgroundSection"/>
@@ -1655,7 +1655,7 @@
16551655
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
16561656
</actionGroup>
16571657
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeMinimumHeight">
1658-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1658+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
16591659
</actionGroup>
16601660
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeBackgroundColor">
16611661
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,7 +1300,7 @@
13001300
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
13011301
</actionGroup>
13021302
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
1303-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1303+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
13041304
</actionGroup>
13051305
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
13061306
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>
@@ -1444,7 +1444,7 @@
14441444
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
14451445
</actionGroup>
14461446
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeMinimumHeight">
1447-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
1447+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
14481448
</actionGroup>
14491449
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeBackgroundColor">
14501450
<argument name="property" value="PageBuilderBackgroundColor_Hex_White"/>
@@ -1610,7 +1610,7 @@
16101610
<argument name="contentType" value="PageBuilderBannerContentType"/>
16111611
</actionGroup>
16121612
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
1613-
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultProperty"/>
1613+
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultPxProperty"/>
16141614
</actionGroup>
16151615
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
16161616
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
<argument name="property" value="PageBuilderAppearance_Poster"/>
156156
</actionGroup>
157157
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
158-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
158+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
159159
</actionGroup>
160160
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
161161
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderMediaContentTypesTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@
489489
<argument name="property" value="PageBuilderAppearance_Poster"/>
490490
</actionGroup>
491491
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="setMinHeight">
492-
<argument name="property" value="PageBuilderBannerMinimumHeightProperty"/>
492+
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
493493
</actionGroup>
494494
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="setBackgroundColor">
495495
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>

‎app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_banner_form.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@
6767
</formElements>
6868
</field>
6969
<field name="min_height" sortOrder="20" formElement="input">
70+
<argument name="data" xsi:type="array">
71+
<item name="config" xsi:type="array">
72+
<item name="default" xsi:type="string">300px</item>
73+
</item>
74+
</argument>
7075
<settings>
7176
<label translate="true">Minimum Height</label>
7277
<notice translate="true">Minimum height can be a single number with any valid CSS unit (50px, 50%, 50em, 50vh) or a calculation (50% + 50px).</notice>

0 commit comments

Comments
 (0)