Skip to content

Commit e7e10f6

Browse files
PB-378: Full height Banner
1 parent 31059f2 commit e7e10f6

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/banner.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
5151
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
5252
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
53-
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
53+
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/min-height"/>
5454
<style name="text_align" source="text_align"/>
5555
<attribute name="background_images" source="data-background-images"/>
5656
</element>
@@ -115,7 +115,7 @@
115115
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
116116
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
117117
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
118-
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
118+
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/min-height"/>
119119
<style name="text_align" source="text_align"/>
120120
<attribute name="background_images" source="data-background-images"/>
121121
</element>
@@ -180,7 +180,7 @@
180180
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
181181
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
182182
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
183-
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
183+
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/min-height"/>
184184
<style name="text_align" source="text_align"/>
185185
<attribute name="background_images" source="data-background-images"/>
186186
</element>
@@ -250,7 +250,7 @@
250250
</element>
251251
<element name="overlay">
252252
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/overlay-border-radius" persistence_mode="write"/>
253-
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
253+
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/min-height"/>
254254
<style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
255255
<style name="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
256256
<attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color"/>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_banner_form.xml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,14 @@
6767
</formElements>
6868
</field>
6969
<field name="min_height" sortOrder="20" formElement="input">
70-
<argument name="data" xsi:type="array">
71-
<item name="config" xsi:type="array">
72-
<item name="default" xsi:type="number">300</item>
73-
</item>
74-
</argument>
7570
<settings>
7671
<label translate="true">Minimum Height</label>
72+
<notice translate="true">Minimum height can be a single number with any valid CSS unit (50px, 50%, 50em, 50vh) or a calculation (50% + 50px).</notice>
7773
<additionalClasses>
78-
<class name="admin__field-small">true</class>
74+
<class name="admin__field-medium">true</class>
7975
</additionalClasses>
80-
<addAfter translate="true">px</addAfter>
81-
<dataType>text</dataType>
82-
<dataScope>min_height</dataScope>
8376
<validation>
84-
<rule name="validate-number" xsi:type="boolean">true</rule>
77+
<rule name="validate-calc" xsi:type="boolean">true</rule>
8578
</validation>
8679
</settings>
8780
</field>

0 commit comments

Comments
 (0)