Skip to content

Commit 9f9ee2a

Browse files
anthoulaanthoula
committed
MC-5079: Add Box Sizing to Storefront Styles (Border & Height Storefront Issues)
- add new test to assert banner poster and collage left with borders and padding is equal to height - add new banner css selectors
1 parent 1409a5e commit 9f9ee2a

File tree

3 files changed

+90
-0
lines changed

3 files changed

+90
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBannerSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<element name="baseJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-banner-wrapper')[{{arg1}} - 1]" parameterized="true"/>
1414
<element name="hidden" type="button" selector="(//div[@data-role='banner'])[{{arg1}}][contains(@style, 'display: none')]" parameterized="true"/>
1515
<element name="notHidden" type="button" selector="(//div[@data-role='banner'])[{{arg1}}][not(contains(@style, 'display: none'))]" parameterized="true"/>
16+
<element name="wrapperCSS" type="button" selector="[data-role=banner] [data-element=wrapper]"/>
1617
<element name="wrapperJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-banner-wrapper')[{{arg1}} - 1]" parameterized="true"/>
1718
<element name="overlay" type="button" selector="(//div[@data-role='banner'])[{{arg1}}]//div[@data-element='overlay']" parameterized="true"/>
1819
<element name="overlayJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-overlay')[{{arg1}} - 1]" parameterized="true"/>
@@ -69,6 +70,7 @@
6970
<element name="base" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]" parameterized="true"/>
7071
<element name="hidden" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
7172
<element name="notHidden" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
73+
<element name="wrapperCSS" type="button" selector="[data-role=banner] [data-element=wrapper]"/>
7274
<element name="wrapperJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-banner-wrapper')[{{arg1}} - 1]" parameterized="true"/>
7375
<element name="overlay" type="button" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-banner')])[{{arg1}}]//div[@data-element='overlay']" parameterized="true"/>
7476
<element name="overlayJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-overlay')[{{arg1}} - 1]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,6 +916,50 @@
916916
<seeElement selector="{{BannerOnFrontend.margins('1', PageBuilderMarginsPropertyUnique.value)}}" stepKey="seeMarginsStorefront"/>
917917
<seeElement selector="{{BannerOnFrontend.collagePadding('1', PageBuilderPaddingPropertyUnique.value)}}" stepKey="seePaddingStorefront"/>
918918
</test>
919+
<test name="BannerCollageLeftWithBordersAndPaddingEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
920+
<annotations>
921+
<features value="PageBuilder"/>
922+
<stories value="Banner"/>
923+
<title value="Collage Left - Banner height is equal to min height"/>
924+
<description value="A user can see Banner collage left height with borders and padding is equal to min height"/>
925+
<severity value="CRITICAL"/>
926+
<useCaseId value="MC-5079"/>
927+
<testCaseId value="MC-5797"/>
928+
<group value="pagebuilder"/>
929+
<group value="pagebuilder-banner"/>
930+
<group value="pagebuilder-bannerCommon"/>
931+
</annotations>
932+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
933+
<argument name="contentType" value="PageBuilderBannerContentType"/>
934+
</actionGroup>
935+
<actionGroup ref="expandPageBuilderPanelGroup" after="enterPageTitle" stepKey="expandGroup">
936+
<argument name="group" value="PageBuilderBannerContentType"/>
937+
</actionGroup>
938+
<actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
939+
<argument name="contentType" value="PageBuilderBannerContentType"/>
940+
</actionGroup>
941+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel">
942+
<argument name="contentType" value="PageBuilderBannerContentType"/>
943+
</actionGroup>
944+
<actionGroup ref="chooseVisualSelectOption" after="openEditPanel" stepKey="enterAppearanceCollageLeftProperty">
945+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
946+
</actionGroup>
947+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
948+
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultProperty"/>
949+
</actionGroup>
950+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
951+
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
952+
</actionGroup>
953+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
954+
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
955+
</actionGroup>
956+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
957+
<argument name="contentType" value="PageBuilderBannerContentType"/>
958+
</actionGroup>
959+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
960+
<argument name="content" value="{{BannerOnFrontend.wrapperCSS}}"/>
961+
</actionGroup>
962+
</test>
919963
<test name="BannerCollageLeftUpdateAllAttributes">
920964
<annotations>
921965
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1610,6 +1610,50 @@
16101610
<switchToNextTab stepKey="switchToNextTab"/>
16111611
<seeCurrentUrlEquals url="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="seeCurrentUrlEquals"/>
16121612
</test>
1613+
<test name="BannerPosterWithBordersAndPaddingEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
1614+
<annotations>
1615+
<features value="PageBuilder"/>
1616+
<stories value="Banner"/>
1617+
<title value="Poster - Height is equal to min height"/>
1618+
<description value="A user can see Banner poster height with borders and padding is equal to min height"/>
1619+
<severity value="CRITICAL"/>
1620+
<useCaseId value="MC-5079"/>
1621+
<testCaseId value="MC-5794"/>
1622+
<group value="pagebuilder"/>
1623+
<group value="pagebuilder-banner"/>
1624+
<group value="pagebuilder-bannerCommon"/>
1625+
</annotations>
1626+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1627+
<argument name="contentType" value="PageBuilderBannerContentType"/>
1628+
</actionGroup>
1629+
<actionGroup ref="expandPageBuilderPanelGroup" after="enterPageTitle" stepKey="expandGroup">
1630+
<argument name="group" value="PageBuilderBannerContentType"/>
1631+
</actionGroup>
1632+
<actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
1633+
<argument name="contentType" value="PageBuilderBannerContentType"/>
1634+
</actionGroup>
1635+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel">
1636+
<argument name="contentType" value="PageBuilderBannerContentType"/>
1637+
</actionGroup>
1638+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
1639+
<argument name="property" value="PageBuilderBannerMinimumHeightDefaultProperty"/>
1640+
</actionGroup>
1641+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
1642+
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
1643+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1644+
</actionGroup>
1645+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
1646+
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
1647+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1648+
</actionGroup>
1649+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1650+
<argument name="contentType" value="PageBuilderBannerContentType"/>
1651+
</actionGroup>
1652+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
1653+
<argument name="content" value="{{BannerOnFrontend.wrapperCSS}}"/>
1654+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1655+
</actionGroup>
1656+
</test>
16131657
<test name="BannerPosterHtmlValueInButtons" extends="BannerCollageCenterHtmlValueInButtons">
16141658
<annotations>
16151659
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)