Skip to content

Commit 1409a5e

Browse files
anthoulaanthoula
committed
MC-5079: Add Box Sizing to Storefront Styles (Border & Height Storefront Issues)
- move test to poster apperance
1 parent 166b130 commit 1409a5e

File tree

2 files changed

+44
-44
lines changed

2 files changed

+44
-44
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1366,6 +1366,50 @@
13661366
<switchToNextTab stepKey="switchToNextTab"/>
13671367
<seeCurrentUrlEquals url="{{PageBuilderSlideItemLinkURL_External.value}}" stepKey="seeCurrentUrlEquals"/>
13681368
</test>
1369+
<test name="SlideItemPosterWithBordersAndPaddingEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
1370+
<annotations>
1371+
<features value="PageBuilder"/>
1372+
<stories value="Slider"/>
1373+
<title value="Poster - Height is equal to min height"/>
1374+
<description value="A user can see poster Slide height with borders and padding is equal to min height"/>
1375+
<severity value="CRITICAL"/>
1376+
<useCaseId value="MC-5079"/>
1377+
<testCaseId value="MC-5792"/>
1378+
<group value="pagebuilder"/>
1379+
<group value="pagebuilder-slide"/>
1380+
<group value="pagebuilder-slideItemPoster"/>
1381+
</annotations>
1382+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1383+
<argument name="contentType" value="PageBuilderSliderContentType"/>
1384+
</actionGroup>
1385+
<actionGroup ref="expandPageBuilderPanelGroup" after="enterPageTitle" stepKey="expandGroup">
1386+
<argument name="group" value="PageBuilderSliderContentType"/>
1387+
</actionGroup>
1388+
<actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
1389+
<argument name="contentType" value="PageBuilderSliderContentType"/>
1390+
</actionGroup>
1391+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" after="dragContentTypeToStage" stepKey="openEditPanel">
1392+
<argument name="section" value="SlideOnBackend"/>
1393+
</actionGroup>
1394+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
1395+
<argument name="property" value="PageBuilderSlideItemMinimumHeight_300"/>
1396+
</actionGroup>
1397+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
1398+
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
1399+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1400+
</actionGroup>
1401+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
1402+
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
1403+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1404+
</actionGroup>
1405+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1406+
<argument name="contentType" value="PageBuilderSliderContentType"/>
1407+
</actionGroup>
1408+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
1409+
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1410+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1411+
</actionGroup>
1412+
</test>
13691413
<test name="SliderPosterHtmlValueInButtons" extends="SliderCollageCenterHtmlValueInButtons">
13701414
<annotations>
13711415
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -554,50 +554,6 @@
554554
<seeElement selector="{{SlideOnFrontend.margins('1', PageBuilderMarginsPropertyDefault.value)}}" stepKey="seeMarginsStorefront"/>
555555
<seeElement selector="{{SlideOnFrontend.posterPadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="seePaddingStorefront"/>
556556
</test>
557-
<test name="SlideItemWithBordersAndPaddingEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
558-
<annotations>
559-
<features value="PageBuilder"/>
560-
<stories value="Slider"/>
561-
<title value="Slide Item - Height is equal to min height"/>
562-
<description value="A user can see Slide item height with borders and padding is equal to min height"/>
563-
<severity value="CRITICAL"/>
564-
<useCaseId value="MC-5079"/>
565-
<testCaseId value="MC-5792"/>
566-
<group value="pagebuilder"/>
567-
<group value="pagebuilder-slide"/>
568-
<group value="pagebuilder-slideItemCommon"/>
569-
</annotations>
570-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
571-
<argument name="contentType" value="PageBuilderSliderContentType"/>
572-
</actionGroup>
573-
<actionGroup ref="expandPageBuilderPanelGroup" after="enterPageTitle" stepKey="expandGroup">
574-
<argument name="group" value="PageBuilderSliderContentType"/>
575-
</actionGroup>
576-
<actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
577-
<argument name="contentType" value="PageBuilderSliderContentType"/>
578-
</actionGroup>
579-
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" after="dragContentTypeToStage" stepKey="openEditPanel">
580-
<argument name="section" value="SlideOnBackend"/>
581-
</actionGroup>
582-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
583-
<argument name="property" value="PageBuilderSlideItemMinimumHeight_300"/>
584-
</actionGroup>
585-
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
586-
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
587-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
588-
</actionGroup>
589-
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
590-
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
591-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
592-
</actionGroup>
593-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
594-
<argument name="contentType" value="PageBuilderSliderContentType"/>
595-
</actionGroup>
596-
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
597-
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
598-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
599-
</actionGroup>
600-
</test>
601557
<test name="SlideItemMoveSlideItemsToRearrange">
602558
<annotations>
603559
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)