Skip to content

Commit 9c8314b

Browse files
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Remove uploader element and apply no border style to main element if image is contained within
1 parent 53a53ec commit 9c8314b

File tree

2 files changed

+8
-12
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml

2 files changed

+8
-12
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/image.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,17 @@
2525
<elements>
2626
<element name="main">
2727
<style name="text_align" source="text_align"/>
28+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
29+
<style name="border_color" source="border_color"/>
30+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
31+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
2832
<style name="display" source="display" converter="Magento_PageBuilder/js/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
2933
<style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
3034
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
3135
<attribute name="name" source="data-role"/>
3236
<attribute name="appearance" source="data-appearance"/>
3337
<css name="css_classes"/>
3438
</element>
35-
<element name="uploader">
36-
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
37-
<style name="border_color" source="border_color"/>
38-
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
39-
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
40-
</element>
4139
<element name="desktop_image">
4240
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
4341
<style name="border_color" source="border_color"/>

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/image/full-width/preview.html

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,10 @@
77

88
<div class="pagebuilder-content-type pagebuilder-image type-nested" event="{ mouseover: onMouseOver, mouseout: onMouseOut }, mouseoverBubble: false">
99
<render args="getOptions().template" />
10-
<figure attr="data.main.attributes" ko-style="data.main.style" css="data.main.css">
11-
<div attr="!data.desktop_image.attributes().src ? data.uploader.attributes : {}" ko-style="!data.desktop_image.attributes().src ? data.uploader.style : {}" css="!data.desktop_image.attributes().src ? data.uploader.css : {}">
12-
<scope args="getUploader().getUiComponent()">
13-
<render />
14-
</scope>
15-
</div>
10+
<figure attr="data.main.attributes" ko-style="Object.assign({}, data.main.style(), !data.desktop_image.attributes().src ? {} : {borderStyle: 'none'})" css="data.main.css">
11+
<scope args="getUploader().getUiComponent()">
12+
<render />
13+
</scope>
1614
<img if="data.desktop_image.attributes().src"
1715
attr="data.desktop_image.attributes"
1816
class="preview-image"

0 commit comments

Comments
 (0)