Skip to content

Commit 53a53ec

Browse files
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Move border styles on image from main to desktop/mobile_image
1 parent 36d49df commit 53a53ec

File tree

2 files changed

+19
-7
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml

2 files changed

+19
-7
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/image.xml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,35 @@
2525
<elements>
2626
<element name="main">
2727
<style name="text_align" source="text_align"/>
28-
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
29-
<style name="border_color" source="border_color"/>
30-
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
31-
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
3228
<style name="display" source="display" converter="Magento_PageBuilder/js/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
3329
<style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
3430
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
3531
<attribute name="name" source="data-role"/>
3632
<attribute name="appearance" source="data-appearance"/>
3733
<css name="css_classes"/>
3834
</element>
35+
<element name="uploader">
36+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
37+
<style name="border_color" source="border_color"/>
38+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
39+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
40+
</element>
3941
<element name="desktop_image">
42+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
43+
<style name="border_color" source="border_color"/>
44+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
45+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
4046
<static_style source="max-width" value="100%"/>
4147
<static_style source="height" value="auto"/>
4248
<attribute name="image" source="src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
4349
<attribute name="alt" source="alt"/>
4450
<attribute name="title_attribute" source="title"/>
4551
</element>
4652
<element name="mobile_image">
53+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
54+
<style name="border_color" source="border_color"/>
55+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
56+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
4757
<static_style source="max-width" value="100%"/>
4858
<static_style source="height" value="auto"/>
4959
<attribute name="mobile_image" source="src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/image/full-width/preview.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88
<div class="pagebuilder-content-type pagebuilder-image type-nested" event="{ mouseover: onMouseOver, mouseout: onMouseOut }, mouseoverBubble: false">
99
<render args="getOptions().template" />
1010
<figure attr="data.main.attributes" ko-style="data.main.style" css="data.main.css">
11-
<scope args="getUploader().getUiComponent()">
12-
<render />
13-
</scope>
11+
<div attr="!data.desktop_image.attributes().src ? data.uploader.attributes : {}" ko-style="!data.desktop_image.attributes().src ? data.uploader.style : {}" css="!data.desktop_image.attributes().src ? data.uploader.css : {}">
12+
<scope args="getUploader().getUiComponent()">
13+
<render />
14+
</scope>
15+
</div>
1416
<img if="data.desktop_image.attributes().src"
1517
attr="data.desktop_image.attributes"
1618
class="preview-image"

0 commit comments

Comments
 (0)