Skip to content

Commit 9578343

Browse files
author
Hwashiang Yu
committed
MC-5383: Option Menus, Heading Inline Editor & tinyMCE Inline Editor Are Cut Off on Full Screen View
- Updated style and logic for preview options menu
1 parent d004259 commit 9578343

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/_preview.less

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -327,20 +327,20 @@
327327
height: 40px;
328328
opacity: 0;
329329
position: absolute;
330-
right: 0;
330+
right: 50%;
331331
text-align: center;
332332
top: 0;
333-
transform: translate(0, -50%);
333+
transform: translate(50%, -50%);
334334
-moz-transition: opacity 200ms, visibility 200ms;
335335
-o-transition: opacity 200ms, visibility 200ms;
336336
-webkit-transition: opacity 200ms, visibility 200ms;
337337
transition: opacity 200ms, visibility 200ms;
338338
visibility: hidden;
339339
z-index: 105;
340340

341-
&.pagebuilder-options-middle {
342-
right: 50%;
343-
transform: translate(50%, -50%);
341+
&.pagebuilder-options-right {
342+
right: 0;
343+
transform: translate(0, -50%);
344344
}
345345

346346
&.pagebuilder-options-visible {

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview.js

Lines changed: 4 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/preview.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,10 @@ export default class Preview {
197197
const middleOfPreview = currentTarget.getBoundingClientRect().left + currentTarget.offsetWidth / 2;
198198

199199
// if there are space for moving options menu to the middle
200-
if (window.innerWidth - middleOfPreview > optionsMenu.width() / 2) {
201-
optionsMenu.parent().addClass("pagebuilder-options-middle");
200+
if (!(window.innerWidth - middleOfPreview > optionsMenu.width() / 2)) {
201+
optionsMenu.parent().addClass("pagebuilder-options-right");
202+
} else {
203+
optionsMenu.parent().removeClass("pagebuilder-options-right");
202204
}
203205

204206
optionsMenu.parent().addClass("pagebuilder-options-visible");
@@ -229,9 +231,6 @@ export default class Preview {
229231
}
230232

231233
optionsMenu.parent().removeClass("pagebuilder-options-visible");
232-
_.delay(() => {
233-
optionsMenu.parent().removeClass("pagebuilder-options-middle");
234-
}, 200);
235234
$(currentTarget).removeClass("pagebuilder-content-type-active");
236235
}
237236
}, 100); // 100 ms delay to allow for users hovering over other elements

0 commit comments

Comments
 (0)