Skip to content

Commit d004259

Browse files
author
Hwashiang Yu
committed
MC-5383: Option Menus, Heading Inline Editor & tinyMCE Inline Editor Are Cut Off on Full Screen View
- Reverted undesired changes to wysiwyg-interface.ts - Fixed spacing in column-group default less - Removed extra spaces in _preview.less - Minor space fix in heading preview template
1 parent 5f2482f commit d004259

File tree

4 files changed

+18
-5
lines changed

4 files changed

+18
-5
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/_preview.less

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,8 +349,6 @@
349349
visibility: visible;
350350
}
351351

352-
353-
354352
.pagebuilder-options-wrapper {
355353
background: @color-white;
356354
border: 1px solid rgba(153, 153, 153, .7);

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/column-group/_default.less

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,11 +311,13 @@
311311
top: 100%;
312312
width: 0;
313313
}
314+
314315
&:before {
315316
border-top-color: @color-dark-grayish-orange;
316317
margin-top: 1px;
317318
z-index: 3;
318319
}
320+
319321
&:after {
320322
border-top-color: @color-lazy-sun;
321323
z-index: 4;
@@ -328,12 +330,14 @@
328330
&:after {
329331
top: -25%;
330332
}
333+
331334
&:before {
332335
border-bottom-color: @color-lazy-sun;
333336
border-top-color: transparent;
334337
margin-top: 1px;
335338
z-index: 4;
336339
}
340+
337341
&:after {
338342
border-bottom-color: @color-dark-grayish-orange;
339343
border-top-color: transparent;

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/heading/default/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<div class="pagebuilder-content-type pagebuilder-heading" event="{ mouseover: onMouseOver, mouseout: onMouseOut }, mouseoverBubble: false">
99
<render args="getOptions().template" />
10-
<div class="pagebuilder-toolbar-container" tabindex="0" event="{ focusin: toolbar.onFocusIn, focusout: toolbar.onFocusOut}">
10+
<div class="pagebuilder-toolbar-container" tabindex="0" event="{ focusin: toolbar.onFocusIn, focusout: toolbar.onFocusOut }">
1111
<with args="toolbar">
1212
<render args="template" />
1313
</with>

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/wysiwyg/wysiwyg-interface.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,25 @@ import DataStore from "../data-store";
99
/**
1010
* Provides an interface for the constructor of a WysiwygInterface object
1111
*/
12-
export type WysiwygConstructorInterface = new (
12+
export interface WysiwygConstructorInterface {
13+
/**
14+
* @param {String} contentTypeId The ID in the registry of the content type.
15+
* @param {String} elementId The ID of the editor element in the DOM.
16+
* @param {AdditionalDataConfigInterface} config The configuration for the wysiwyg.
17+
* @param {DataStore} dataStore The datastore to store the content in.
18+
* @param {String} fieldName The key in the provided datastore to set the data.
19+
* @param {string} stageId The ID in the registry of the stage containing the content type.
20+
* @return {WysiwygInterface}
21+
*/
22+
new (
1323
contentTypeId: string,
1424
elementId: string,
1525
config: AdditionalDataConfigInterface,
1626
dataStore: DataStore,
1727
fieldName: string,
1828
stageId: string,
19-
) => WysiwygInterface;
29+
): WysiwygInterface;
30+
}
2031

2132
/**
2233
* Describes an instance of a WYSIWYG component not specific to a specific editor

0 commit comments

Comments
 (0)