Skip to content

Commit 8f63c28

Browse files
MC-855: Pagebuilder - Tab Minimum Height Displays Differently On Stage & Storefront
1 parent 9293b07 commit 8f63c28

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TabData.xml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -237,28 +237,4 @@
237237
<data key="fieldName">background_attachment</data>
238238
<data key="value">fixed</data>
239239
</entity>
240-
<entity name="PageBuilderTabDefaultPaddingTopProperty" type="pagebuilder_padding_top_property">
241-
<data key="name">Padding Top</data>
242-
<data key="section">advanced</data>
243-
<data key="fieldName">paddingTop</data>
244-
<data key="value">40</data>
245-
</entity>
246-
<entity name="PageBuilderTabDefaultPaddingRightProperty" type="pagebuilder_padding_right_property">
247-
<data key="name">Padding Right</data>
248-
<data key="section">advanced</data>
249-
<data key="fieldName">paddingRight</data>
250-
<data key="value">40</data>
251-
</entity>
252-
<entity name="PageBuilderTabDefaultPaddingLeftProperty" type="pagebuilder_padding_left_property">
253-
<data key="name">Padding Left</data>
254-
<data key="section">advanced</data>
255-
<data key="fieldName">paddingLeft</data>
256-
<data key="value">40</data>
257-
</entity>
258-
<entity name="PageBuilderTabDefaultPaddingBottomProperty" type="pagebuilder_padding_bottom_property">
259-
<data key="name">Padding Bottom</data>
260-
<data key="section">advanced</data>
261-
<data key="fieldName">paddingBottom</data>
262-
<data key="value">40</data>
263-
</entity>
264240
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemConfigurationTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@
599599
<seeElement selector="{{TabOnStorefront.tabContentBackgroundColor('2', PageBuilderTabBackgroundColorGreen.rgb)}}" stepKey="seeTab2BackgroundColor"/>
600600
<seeElement selector="{{TabOnStorefront.tabContentMinimumHeight('2', PageBuilderTabMinimumHeight600Property.value)}}" stepKey="seeTab2MinHeight"/>
601601
<comment userInput="User sees Tab 2 with height that equals to sum of min-height + paddingTop + paddingBottom" stepKey="verifyMinHeight"/>
602-
<executeJS function="return {{PageBuilderTabMinimumHeight600Property.value}} + {{PageBuilderTabDefaultPaddingTopProperty.value}} + {{PageBuilderTabDefaultPaddingBottomProperty.value}}" stepKey="tab2ExpectedHeight"/>
602+
<executeJS function="return {{PageBuilderTabMinimumHeight600Property.value}} + {{PageBuilderPaddingProperty40.paddingTop}} + {{PageBuilderPaddingProperty40.paddingBottom}}" stepKey="tab2ExpectedHeight"/>
603603
<executeJS function="return document.querySelector('{{TabOnStorefront.tabContent('2')}}').offsetHeight" stepKey="tab2Height"/>
604604
<assertEquals stepKey="assertTabMinHeight">
605605
<expectedResult type="variable">tab2ExpectedHeight</expectedResult>

0 commit comments

Comments
 (0)