Skip to content

Commit 9293b07

Browse files
MC-855: Pagebuilder - Tab Minimum Height Displays Differently On Stage & Storefront
1 parent b0aec43 commit 9293b07

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TabData.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,4 +237,28 @@
237237
<data key="fieldName">background_attachment</data>
238238
<data key="value">fixed</data>
239239
</entity>
240+
<entity name="PageBuilderTabDefaultPaddingTopProperty" type="pagebuilder_padding_top_property">
241+
<data key="name">Padding Top</data>
242+
<data key="section">advanced</data>
243+
<data key="fieldName">paddingTop</data>
244+
<data key="value">40</data>
245+
</entity>
246+
<entity name="PageBuilderTabDefaultPaddingRightProperty" type="pagebuilder_padding_right_property">
247+
<data key="name">Padding Right</data>
248+
<data key="section">advanced</data>
249+
<data key="fieldName">paddingRight</data>
250+
<data key="value">40</data>
251+
</entity>
252+
<entity name="PageBuilderTabDefaultPaddingLeftProperty" type="pagebuilder_padding_left_property">
253+
<data key="name">Padding Left</data>
254+
<data key="section">advanced</data>
255+
<data key="fieldName">paddingLeft</data>
256+
<data key="value">40</data>
257+
</entity>
258+
<entity name="PageBuilderTabDefaultPaddingBottomProperty" type="pagebuilder_padding_bottom_property">
259+
<data key="name">Padding Bottom</data>
260+
<data key="section">advanced</data>
261+
<data key="fieldName">paddingBottom</data>
262+
<data key="value">40</data>
263+
</entity>
240264
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemConfigurationTests.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,9 +599,10 @@
599599
<seeElement selector="{{TabOnStorefront.tabContentBackgroundColor('2', PageBuilderTabBackgroundColorGreen.rgb)}}" stepKey="seeTab2BackgroundColor"/>
600600
<seeElement selector="{{TabOnStorefront.tabContentMinimumHeight('2', PageBuilderTabMinimumHeight600Property.value)}}" stepKey="seeTab2MinHeight"/>
601601
<comment userInput="User sees Tab 2 with height that equals to sum of min-height + paddingTop + paddingBottom" stepKey="verifyMinHeight"/>
602+
<executeJS function="return {{PageBuilderTabMinimumHeight600Property.value}} + {{PageBuilderTabDefaultPaddingTopProperty.value}} + {{PageBuilderTabDefaultPaddingBottomProperty.value}}" stepKey="tab2ExpectedHeight"/>
602603
<executeJS function="return document.querySelector('{{TabOnStorefront.tabContent('2')}}').offsetHeight" stepKey="tab2Height"/>
603604
<assertEquals stepKey="assertTabMinHeight">
604-
<expectedResult type="variable">680</expectedResult>
605+
<expectedResult type="variable">tab2ExpectedHeight</expectedResult>
605606
<actualResult type="variable">tab2Height</actualResult>
606607
</assertEquals>
607608
</test>

0 commit comments

Comments
 (0)