Skip to content

Commit 7fb3d87

Browse files
committed
#436: Cannot Drag and Drop Image to Upload Area in Banner, Slide in Safari, IE11 - Added changes for MFTF tests
1 parent 473f93c commit 7fb3d87

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/AddInvalidFileToStageActionGroup.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,15 @@
1515
<argument name="contentType" defaultValue="PageBuilderImageContentType"/>
1616
<argument name="file" defaultValue="PageBuilderImage_InvalidFileType"/>
1717
<argument name="section" defaultValue="ImageOnStageWithoutImageUploaded"/>
18-
<argument name="sectionArea" defaultValue="ImageOnStageWithoutImageUploaded.base('1')" />
19-
<argument name="attachInput" defaultValue="ImageOnStageWithoutImageUploaded.attachImageBtn" />
2018
<argument name="filePreview" defaultValue="ImageOnStageWithoutImageUploaded.imagePreview"/>
2119
<argument name="fileSource" defaultValue=""/>
2220
</arguments>
23-
<waitForElementVisible selector="{{sectionArea}}" stepKey="waitForSectionArea"/>
21+
<waitForElementVisible selector="{{section.base('1')}}" stepKey="waitForSectionArea"/>
2422
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusContentArea"/>
25-
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(contentType.role, '1')}}" stepKey="hoverSectionArea"/>
23+
<moveMouseOver selector="{{section.base('1')}}" stepKey="hoverSectionArea"/>
2624
<waitForPageLoad stepKey="waitForPageLoad"/>
27-
<seeElement selector="{{PageBuilderStage.onHoverUploadImageButton(contentType.role, '1')}}" stepKey="seeUploadImageButton"/>
28-
<attachFile userInput="{{file.value}}" selector="{{attachInput}}" stepKey="attachFile"/>
25+
<waitForElementVisible selector="{{PageBuilderStage.onHoverUploadImageButton(contentType.role, '1')}}" stepKey="waitForUploadImageButton"/>
26+
<attachFile userInput="{{file.value}}" selector="{{section.uploadImageInput('1')}}" stepKey="attachFile"/>
2927
<waitForPageLoad stepKey="waitForFileLoad"/>
3028
<waitForElementVisible selector="{{PageBuilderStage.modal}}" stepKey="waitForModal"/>
3129
<waitForElementVisible selector="{{PageBuilderStage.errorModalMessage(file.errorMessage)}}" stepKey="waitForModalMessage"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest/BannerBackgroundImageInvalidFileTypeValidationTest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
<actionGroup ref="AddInvalidFileToStage" stepKey="AddInvalidFileToStage">
2828
<argument name="contentType" value="PageBuilderBannerContentType"/>
2929
<argument name="section" value="BannerOnBackend"/>
30-
<argument name="sectionArea" value="BannerOnBackend.base('1')"/>
31-
<argument name="attachInput" value="BannerOnBackend.uploadImageInput"/>
3230
<argument name="filePreview" value="BannerOnBackend.backgroundImage('1', PageBuilderImage_InvalidFileType.fileName)"/>
3331
<argument name="fileSource" value="BannerOnBackend.imageSourceByIndex('1', PageBuilderImage_InvalidFileType.fileName)"/>
3432
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest/SlideItemBackgroundImageInvalidFileTypeValidationTest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
<actionGroup ref="AddInvalidFileToStage" stepKey="AddInvalidFileToStage">
2828
<argument name="contentType" value="PageBuilderSliderContentType"/>
2929
<argument name="section" value="SlideOnBackend"/>
30-
<argument name="sectionArea" value="SlideOnBackend.all"/>
31-
<argument name="attachInput" value="SlideOnBackend.uploadImageInput"/>
3230
<argument name="filePreview" value="SlideOnBackend.backgroundImage('1', PageBuilderImage_InvalidFileType.fileName)"/>
3331
<argument name="fileSource" value="SlideOnBackend.imageSourceByIndex('1', PageBuilderImage_InvalidFileType.fileName)"/>
3432
</actionGroup>

0 commit comments

Comments
 (0)