Skip to content

Commit 473f93c

Browse files
committed
#436: Cannot Drag and Drop Image to Upload Area in Banner, Slide in Safari, IE11 - Fixed Tests after CR
1 parent a2f2620 commit 473f93c

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/AddInvalidFileToStageActionGroup.xml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<description>Adds invalid file to Content Type and checks validation message</description>
1313
</annotations>
1414
<arguments>
15+
<argument name="contentType" defaultValue="PageBuilderImageContentType"/>
1516
<argument name="file" defaultValue="PageBuilderImage_InvalidFileType"/>
1617
<argument name="section" defaultValue="ImageOnStageWithoutImageUploaded"/>
1718
<argument name="sectionArea" defaultValue="ImageOnStageWithoutImageUploaded.base('1')" />
@@ -20,11 +21,14 @@
2021
<argument name="fileSource" defaultValue=""/>
2122
</arguments>
2223
<waitForElementVisible selector="{{sectionArea}}" stepKey="waitForSectionArea"/>
23-
<moveMouseOver selector="{{sectionArea}}" stepKey="hoverSectionArea"/>
24-
<attachFile userInput="{{file.value}}" selector="{{attachInput}}" stepKey="attachFile"/>
24+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusContentArea"/>
25+
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(contentType.role, '1')}}" stepKey="hoverSectionArea"/>
2526
<waitForPageLoad stepKey="waitForPageLoad"/>
27+
<seeElement selector="{{PageBuilderStage.onHoverUploadImageButton(contentType.role, '1')}}" stepKey="seeUploadImageButton"/>
28+
<attachFile userInput="{{file.value}}" selector="{{attachInput}}" stepKey="attachFile"/>
29+
<waitForPageLoad stepKey="waitForFileLoad"/>
2630
<waitForElementVisible selector="{{PageBuilderStage.modal}}" stepKey="waitForModal"/>
27-
<waitForElementVisible selector="{{PageBuilderStage.errorModal(file.errorMessage)}}" stepKey="waitForModalMessage"/>
31+
<waitForElementVisible selector="{{PageBuilderStage.errorModalMessage(file.errorMessage)}}" stepKey="waitForModalMessage"/>
2832
<waitForElementVisible selector="{{PageBuilderStage.modalOk}}" stepKey="waitForModalOkButton"/>
2933
<click selector="{{PageBuilderStage.modalOk}}" stepKey="clickModalOkButton"/>
3034
<waitForElementNotVisible selector="{{PageBuilderStage.modal}}" stepKey="waitForModalGone"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection/PageBuilderStageSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<!-- It's safer to click the label, as Selenium will complain if it's not clicking the exact element -->
2727
<element name="modalDoNotShowThisAgain" type="input" selector="aside.modal-popup._show input[name='modal-dnsa'] + label"/>
2828
<element name="errorModal" type="button" selector="//div[@class='modal-content']//div[contains(text(), '{{arg1}}')]" parameterized="true"/>
29+
<element name="errorModalMessage" type="text" selector="//aside[contains(@class,'modal-popup')]//div[@class='modal-content']//div[.=&quot;{{arg1}}&quot;]" parameterized="true"/>
2930
<element name="dropZone" type="button" selector="(//div[contains(@class, &quot;{{arg1}}-container&quot;)])[{{arg2}}]//div[contains(@class,&quot;pagebuilder-drop-indicator&quot;)][{{arg3}}]" parameterized="true"/>
3031
<element name="contentTypeTotalInStage" type="button" selector=".pagebuilder-content-type.pagebuilder-{{arg1}}" parameterized="true"/>
3132
<element name="contentTypeInStage" type="button" selector="//div[contains(@class, &quot;pagebuilder-content-type&quot;) and contains(@class, &quot;pagebuilder-{{arg1}}&quot;)]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest/BannerBackgroundImageInvalidFileTypeValidationTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<argument name="contentType" value="PageBuilderBannerContentType"/>
2626
</actionGroup>
2727
<actionGroup ref="AddInvalidFileToStage" stepKey="AddInvalidFileToStage">
28+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2829
<argument name="section" value="BannerOnBackend"/>
2930
<argument name="sectionArea" value="BannerOnBackend.base('1')"/>
3031
<argument name="attachInput" value="BannerOnBackend.uploadImageInput"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest/SlideItemBackgroundImageInvalidFileTypeValidationTest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@
2525
<argument name="contentType" value="PageBuilderSliderContentType"/>
2626
</actionGroup>
2727
<actionGroup ref="AddInvalidFileToStage" stepKey="AddInvalidFileToStage">
28+
<argument name="contentType" value="PageBuilderSliderContentType"/>
2829
<argument name="section" value="SlideOnBackend"/>
29-
<argument name="sectionArea" value="SlideOnBackend.base('1')"/>
30+
<argument name="sectionArea" value="SlideOnBackend.all"/>
3031
<argument name="attachInput" value="SlideOnBackend.uploadImageInput"/>
3132
<argument name="filePreview" value="SlideOnBackend.backgroundImage('1', PageBuilderImage_InvalidFileType.fileName)"/>
3233
<argument name="fileSource" value="SlideOnBackend.imageSourceByIndex('1', PageBuilderImage_InvalidFileType.fileName)"/>

0 commit comments

Comments
 (0)