Skip to content

Commit 7e083ab

Browse files
committed
MC-4265: update composer.json for magento/module-page-builder-analytics
- fix buttons configuration
1 parent 7b5e195 commit 7e083ab

File tree

4 files changed

+89
-2
lines changed

4 files changed

+89
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/button_item.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
reader="Magento_PageBuilder/js/master-format/read/configurable">
3030
<elements>
3131
<element name="main">
32-
<style name="display" source="display" converter="Magento_PageBuilder/js/content-type/buttons/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
32+
<style name="display" source="display" converter="Magento_PageBuilder/js/content-type/button-item/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
3333
<attribute name="name" source="data-role"/>
3434
<attribute name="appearance" source="data-appearance"/>
3535
<css name="css_classes"/>

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/buttons.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<style name="border_color" source="border_color"/>
3333
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
3434
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
35-
<style name="display" source="display" converter="Magento_PageBuilder/js/content-type/buttons/converter/style/display/inline-block" preview_converter="Magento_PageBuilder/js/converter/style/preview/display/inline-block"/>
35+
<style name="display" source="display" converter="Magento_PageBuilder/js/content-type/buttons/converter/style/display/inline-block" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
3636
<style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
3737
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
3838
<attribute name="name" source="data-role"/>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/button-item/converter/style/display.js

Lines changed: 51 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright © Magento, Inc. All rights reserved.
3+
* See COPYING.txt for license details.
4+
*/
5+
6+
import ConverterInterface from "../../../../converter/converter-interface";
7+
import {DataObject} from "../../../../data-store";
8+
9+
/**
10+
* @api
11+
*/
12+
export default class Display implements ConverterInterface {
13+
/**
14+
* Convert value to internal format
15+
*
16+
* @param value string
17+
* @returns {string | object}
18+
*/
19+
public fromDom(value: string): boolean {
20+
return !(value === "none");
21+
}
22+
23+
/**
24+
* Convert value to knockout format, if buttons are displayed they should be inline block
25+
*
26+
* @param {string} name
27+
* @param {DataObject} data
28+
* @returns {string}
29+
*/
30+
public toDom(name: string, data: DataObject): string {
31+
if (typeof data[name] !== "undefined" && data[name] === false) {
32+
return "none";
33+
}
34+
return "inline-block";
35+
}
36+
}

0 commit comments

Comments
 (0)