Skip to content

Commit 7b5e195

Browse files
committed
Merge branch 'MC-4265-metapackage' of github.com:magento-obsessive-owls/magento2-page-builder into MC-4265-metapackage
2 parents a517eeb + 385c30f commit 7b5e195

File tree

44 files changed

+613
-441
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+613
-441
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeSliderActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
</arguments>
1515
<comment userInput="Adding Slide" stepKey="comment"/>
1616
<executeJS function="return document.getElementsByClassName('pagebuilder-slide').length+1" stepKey="initialNumberOfSlidesPlusOne"/>
17+
<scrollTo selector="{{PageBuilderPanel.searchPanel}}" x="0" y="-150" stepKey="scrollToSearchPanel"/>
1718
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide"/>
1819
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderSliderContentType.role, slideGroupIndex)}}" stepKey="mouseOverSlider"/>
1920
<waitForPageLoad stepKey="waitForPageLoad1"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="ProductsOnStage">
1212
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{arg1}}]" parameterized="true"/>
13+
<element name="price" type="text" selector="//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')]//div[contains(@data-role,'priceBox')]"/>
1314
<element name="hidden" type="text" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
1415
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1516
<element name="product" type="text" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{arg1}}]//ol//li[contains(@class,'product-item')]" parameterized="true"/>
@@ -47,6 +48,7 @@
4748
</section>
4849
<section name="ProductsOnStorefront">
4950
<element name="base" type="text" selector="(//div[contains(@data-role,'products')])[{{arg1}}]" parameterized="true"/>
51+
<element name="price" type="text" selector="//div[contains(@data-role,'products')]//div[contains(@data-role,'priceBox')]"/>
5052
<element name="hidden" type="text" selector="(//div[contains(@data-role,'products')])[{{arg1}}][contains(@style, 'display: none')]" parameterized="true"/>
5153
<element name="notHidden" type="text" selector="(//div[contains(@data-role,'products')])[{{arg1}}][not(contains(@style, 'display: none'))]" parameterized="true"/>
5254
<element name="product" type="text" selector="(//div[contains(@data-role,'products')])[{{arg1}}]//ol//li[contains(@class,'product-item')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@
5858
<group value="pagebuilder"/>
5959
<group value="pagebuilder-banner"/>
6060
<group value="pagebuilder-bannerCommon"/>
61+
<skip>
62+
<issueId value="MC-5023"/>
63+
</skip>
6164
</annotations>
6265
<before>
6366
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1438,6 +1438,7 @@
14381438
<!-- Validate Slide 1 Is Shown -->
14391439
<comment userInput="Validate Slide 1 Is Shown" stepKey="commentValidateStage1"/>
14401440
<seeElement selector="{{SlideOnBackend.emptySlide('1')}}" stepKey="seeFirstSlideOnStage"/>
1441+
<click selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" stepKey="clickSlideOptionsMenu"/>
14411442
<seeElement selector="{{SlideOnBackend.optionsMenu('1')}}" stepKey="seeSlideOptionsMenu"/>
14421443
<assertElementContainsAttribute selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" attribute="class" stepKey="assertFirstDotActive">
14431444
<expectedResult type="string">active</expectedResult>
@@ -1454,7 +1455,7 @@
14541455
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanel1Settings"/>
14551456
<!-- User Still Sees Slide Item Option Menu If Hovering Over Slider -->
14561457
<comment userInput="User Still Sees Slide Item Option Menu If Hovering Over Slider" stepKey="commentHoverSlider"/>
1457-
<click selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" stepKey="clickSlideOptionsMenu"/>
1458+
<click selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" stepKey="clickSlideOptionsMenu1"/>
14581459
<waitForPageLoad stepKey="waitForPageLoad"/>
14591460
<seeElement selector="{{SlideOnBackend.optionsMenu('1')}}" stepKey="seeSlideOptionsMenu2"/>
14601461
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderSliderContentType.role, '1')}}" stepKey="mouseOverSlider"/>
@@ -1476,6 +1477,7 @@
14761477
<!-- Validate Slide 2 Is Shown -->
14771478
<comment userInput="Validate Slide 2 Is Shown" stepKey="commentValidateStage2"/>
14781479
<seeElement selector="{{SliderOnStage.slideNavigationDot('1', '2')}}" stepKey="seeSecondDot"/>
1480+
<click selector="{{SliderOnStage.slideNavigationDot('1', '2')}}" stepKey="clickSlide2OptionsMenu"/>
14791481
<seeElement selector="{{SlideOnBackend.optionsMenu('2')}}" stepKey="seeSlideOptionsMenu4"/>
14801482
<assertElementContainsAttribute selector="{{SliderOnStage.slideNavigationDot('1', '2')}}" attribute="class" stepKey="assertSecondDotActive">
14811483
<expectedResult type="string">active</expectedResult>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_default.less

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,12 @@
4343
}
4444
}
4545
.inline-wysiwyg {
46+
line-height: 1.3;
4647
min-height: 50px;
48+
49+
.mce-offscreen-selection {
50+
left: -99999px;
51+
}
4752
}
4853
.mce-tinymce-inline {
4954
left: -2px !important;

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slider/_default.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@
102102
border-radius: 1px;
103103
bottom: 97.5%;
104104
box-shadow: 0 2px 8px 0 rgba(0, 0, 0, .3);
105+
color: @color-pagebuilder-darkest-gray;
105106
font-size: 14px;
106107
left: 50%;
107108
min-width: auto;

app/code/Magento/PageBuilder/view/adminhtml/web/js/binding/sortable.js

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/banner/preview.js

Lines changed: 4 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/buttons/preview.js

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column-group/preview.js

Lines changed: 8 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)