Skip to content

Commit 67952c9

Browse files
committed
MC-5403: Edit With Page Builder Button Is Slow Opening Page Builder And No Loading Indicator After 1st Load
- Fix panel & close icon stickyness with new body overflow hidden
1 parent 087314c commit 67952c9

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_page-builder.less

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,35 +35,46 @@
3535
height: 100%;
3636
left: 0;
3737
overflow: scroll;
38+
overflow-x: hidden;
3839
padding: 0;
3940
position: fixed;
4041
top: 0;
4142
width: 100%;
4243
z-index: 800;
4344

4445
.pagebuilder-header {
45-
background: rgba(255,255,255,.8);
46+
height: 0;
4647
padding: 0;
4748
position: fixed;
49+
position: -webkit-sticky;
50+
position: sticky;
4851
right: 0;
4952
top: 0;
5053
width: auto;
5154
z-index: 101;
5255

5356
.action-close {
54-
background-color: transparent;
57+
background: rgba(255,255,255,.8);
5558
border: none;
5659
border-radius: 0;
5760
box-shadow: none;
58-
display: block;
61+
display: inline-block;
5962
margin: 0;
6063
padding: 15px 20px;
6164
}
6265
}
6366

67+
.pagebuilder-canvas {
68+
padding-top: 25px;
69+
}
70+
6471
.pagebuilder-panel-wrapper {
65-
position: fixed;
6672
top: 0;
73+
bottom: 0;
74+
position: fixed;
75+
position: -webkit-sticky;
76+
position: sticky;
77+
z-index: 102;
6778

6879
.pagebuilder-panel {
6980
height: 100vh;

app/code/Magento/PageBuilder/view/adminhtml/web/template/page-builder.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<div class="admin__field pagebuilder-header">
1010
<i click="toggleFullScreen.bind($data)" css="'icon-pagebuilder-fullscreen': !isFullScreen(), 'action-close': isFullScreen()"></i>
1111
</div>
12-
<br/>
1312
<with args="panel">
1413
<render/>
1514
</with>

0 commit comments

Comments
 (0)