Skip to content

Commit 087314c

Browse files
committed
MC-5403: Edit With Page Builder Button Is Slow Opening Page Builder And No Loading Indicator After 1st Load
- Fix build issues
1 parent 47556c5 commit 087314c

File tree

2 files changed

+29
-11
lines changed

2 files changed

+29
-11
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCreateProductTest.xml

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,14 @@
204204
<comment userInput="Create a new product" stepKey="commentCreateNewProduct"/>
205205
<amOnPage url="{{AdminProductCreatePage.url(AddToDefaultSet.attributeSetId, 'simple')}}" stepKey="navigateToNewProduct"/>
206206
<waitForPageLoad stepKey="waitForProductPage"/>
207+
<!-- Fill the remaining product fields accordingly -->
208+
<comment userInput="Fill the remaining product fields accordingly" stepKey="commentFillProductFields"/>
209+
<actionGroup ref="fillMainProductForm" stepKey="fillMainProductForm">
210+
<argument name="product" value="SimpleProduct"/>
211+
</actionGroup>
207212
<!-- Set background colour of row for custom attribute -->
208213
<comment userInput="Set background colour of row for custom attribute" stepKey="commentSetBackgroundColor"/>
214+
<scrollToTopOfPage stepKey="scrollToTop"/>
209215
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForAttribute">
210216
<argument name="attributeCode" value="$$createWysiwygAttribute.attribute_code$$"/>
211217
</actionGroup>
@@ -218,6 +224,11 @@
218224
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveEditPanelSettings"/>
219225
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen" />
220226
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen"/>
227+
<!-- Save product, before editing row -->
228+
<comment userInput="Save product, before editing row" stepKey="commentSaveProductAfterAttribute"/>
229+
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductAfterAttribute"/>
230+
<waitForPageLoad stepKey="waitForProductSaveAfterAttribute"/>
231+
<waitForElementVisible selector="{{AdminProductMessagesSection.successMessage}}" stepKey="assertSaveMessageSuccessAfterAttribute"/>
221232
<!-- Set background colour of row for description -->
222233
<comment userInput="Set background colour of row for description" stepKey="commentSetDescriptionRowBackgroundColor"/>
223234
<click selector="{{AdminProductContentSection.sectionHeader}}" stepKey="openContentSection"/>
@@ -233,11 +244,6 @@
233244
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveDescriptionEditPanelSettings"/>
234245
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitDescriptionPageBuilderFullScreen" />
235246
<waitForPageLoad stepKey="waitForDescriptionPageLoadExitFullScreen"/>
236-
<!-- Fill the remaining product fields accordingly -->
237-
<comment userInput="Fill the remaining product fields accordingly" stepKey="commentFillProductFields"/>
238-
<actionGroup ref="fillMainProductForm" stepKey="fillMainProductForm">
239-
<argument name="product" value="SimpleProduct"/>
240-
</actionGroup>
241247
<!-- Save product -->
242248
<comment userInput="Save product" stepKey="commentSaveProduct"/>
243249
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProduct"/>
@@ -350,8 +356,14 @@
350356
<comment userInput="Create a new product" stepKey="commentCreateNewProduct"/>
351357
<amOnPage url="{{AdminProductCreatePage.url(AddToDefaultSet.attributeSetId, 'simple')}}" stepKey="navigateToNewProduct"/>
352358
<waitForPageLoad stepKey="waitForProductPage"/>
359+
<!-- Fill the remaining product fields accordingly -->
360+
<comment userInput="Fill the remaining product fields accordingly" stepKey="commentFillProductFields"/>
361+
<actionGroup ref="fillMainProductForm" stepKey="fillMainProductForm">
362+
<argument name="product" value="SimpleProduct"/>
363+
</actionGroup>
353364
<!-- Set background colour of row for our first custom attribute -->
354365
<comment userInput="Set background colour of row for our first custom attribute" stepKey="commentSetBackgroundColor"/>
366+
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
355367
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForAttribute1">
356368
<argument name="attributeCode" value="$$createPageBuilderAttribute1.attribute_code$$"/>
357369
</actionGroup>
@@ -364,8 +376,14 @@
364376
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveEditPanelSettings"/>
365377
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen" />
366378
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen"/>
379+
<!-- Save product, after first attribute -->
380+
<comment userInput="Save product, after first attribute" stepKey="commentSaveProductAfterAttribute"/>
381+
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductAfterAttribute"/>
382+
<waitForPageLoad stepKey="waitForPageLoadSaveProductAfterAttribute"/>
383+
<waitForElementVisible selector="{{AdminProductMessagesSection.successMessage}}" stepKey="assertSaveMessageSuccessAfterAttribute"/>
367384
<!-- Set background colour of row for our second custom attribute -->
368385
<comment userInput="Set background colour of row for our second custom attribute" stepKey="commentSetBackgroundColor1"/>
386+
<scrollToTopOfPage stepKey="scrollToTopOfPage1"/>
369387
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForAttribute2">
370388
<argument name="attributeCode" value="$$createPageBuilderAttribute2.attribute_code$$"/>
371389
</actionGroup>
@@ -378,11 +396,6 @@
378396
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveEditPanelSettings1"/>
379397
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen1" />
380398
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen1"/>
381-
<!-- Fill the remaining product fields accordingly -->
382-
<comment userInput="Fill the remaining product fields accordingly" stepKey="commentFillProductFields"/>
383-
<actionGroup ref="fillMainProductForm" stepKey="fillMainProductForm">
384-
<argument name="product" value="SimpleProduct"/>
385-
</actionGroup>
386399
<!-- Save product -->
387400
<comment userInput="Save product" stepKey="commentSaveProduct"/>
388401
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProduct"/>
@@ -475,6 +488,11 @@
475488
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveEditPanelSettings"/>
476489
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen" />
477490
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen"/>
491+
<!-- Save product after custom attribute -->
492+
<comment userInput="Save product after custom attribute" stepKey="saveProductAfterCustomAttribute"/>
493+
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductAfterAttribute"/>
494+
<waitForPageLoad stepKey="waitForPageLoadSaveProductAfterAttribute"/>
495+
<waitForElementVisible selector="{{AdminProductMessagesSection.successMessage}}" stepKey="assertSaveMessageSuccessAfterAttribute"/>
478496
<!-- Add PageBuilder description -->
479497
<comment userInput="Add PageBuilder description" stepKey="commentAddDescription"/>
480498
<conditionalClick selector="{{AdminProductContentSection.sectionHeader}}" dependentSelector="{{AdminProductContentSection.sectionHeaderIfNotShowing}}" visible="false" stepKey="openContentSection"/>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_panel.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
&.collapsed {
230230
width: 32px;
231231

232-
#pagebuilder-panel {
232+
.pagebuilder-panel {
233233
opacity: 0;
234234
transform: translateX(-100%);
235235
}

0 commit comments

Comments
 (0)