Skip to content

Commit 2832d9d

Browse files
committed
PB-95: Video background for Row
- Hard coding video aspect ratio
1 parent 4eebaf6 commit 2832d9d

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,6 +499,8 @@
499499
<data key="fieldName">video_source</data>
500500
<data key="value">http://obsessive-owls.s3.us-east-2.amazonaws.com/MFTF/avocado.mp4</data>
501501
<data key="renderedValue">http://obsessive-owls.s3.us-east-2.amazonaws.com/MFTF/avocado.mp4</data>
502+
<data key="width">320px</data>
503+
<data key="height">320px</data>
502504
</entity>
503505
<entity name="PageBuilderVideoBackgroundUrl_Invalid_Text" type="pagebuilder_video_background_url">
504506
<data key="name">Video URL</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest.xml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2210,9 +2210,6 @@
22102210
<group value="pagebuilder-row"/>
22112211
<group value="pagebuilder-rowBackground"/>
22122212
<group value="pagebuilder-video-background"/>
2213-
<skip>
2214-
<issueId value="MC-31468"/>
2215-
</skip>
22162213
</annotations>
22172214
<before>
22182215
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>
@@ -2226,13 +2223,6 @@
22262223
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
22272224
<actionGroup ref="logout" stepKey="logout"/>
22282225
</after>
2229-
<!-- Get Aspect Ratio of Actual Video -->
2230-
<openNewTab stepKey="openNewTab"/>
2231-
<amOnUrl url="{{PageBuilderVideoBackgroundUrl_Mp4_URL_Insecure.value}}" stepKey="openVideo"/>
2232-
<executeJS function="return document.querySelector('video').getBoundingClientRect().width" stepKey="expectedVideoWidth"/>
2233-
<executeJS function="return document.querySelector('video').getBoundingClientRect().height" stepKey="expectedVideoHeight"/>
2234-
<executeJS function="return {$expectedVideoWidth} / {$expectedVideoHeight}" stepKey="expectedVideoAspectRatio"/>
2235-
<closeTab stepKey="closeTab"/>
22362226
<!-- Add Video to Contained Row -->
22372227
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage1">
22382228
<argument name="contentType" value="PageBuilderRowContentType"/>
@@ -2278,6 +2268,7 @@
22782268
<argument name="property" value="PageBuilderRowAppearance_FullBleed"/>
22792269
</actionGroup>
22802270
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
2271+
<executeJS function="return parseInt(&quot;{{PageBuilderVideoBackgroundUrl_Mp4_URL_Insecure.width}}&quot;) / parseInt(&quot;{{PageBuilderVideoBackgroundUrl_Mp4_URL_Insecure.height}}&quot;)" stepKey="expectedVideoAspectRatio"/>
22812272
<!-- Validate Stage -->
22822273
<actionGroup ref="validateVideoAspectRatio" stepKey="validateVideoAspectRatioRow1Stage">
22832274
<argument name="section" value="RowOnStage"/>

0 commit comments

Comments
 (0)