Skip to content

Commit 4eebaf6

Browse files
committed
PB-95: Video background for Row
- Fixing broken column MFTF test - Skipping aspect ratio test
1 parent 0f89d71 commit 4eebaf6

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnResizingTest.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -529,9 +529,9 @@
529529
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnX('1')}}').clientWidth" stepKey="columnOneWidth"/>
530530
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnX('2')}}').clientWidth" stepKey="columnTwoWidth"/>
531531
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnX('3')}}').clientWidth" stepKey="columnThreeWidth"/>
532-
<executeJS function="return Math.round({$columnOneWidth}/{$columnTwoWidth}*10)/10" stepKey="columnRatio"/>
532+
<executeJS function="return Math.round(({$columnOneWidth}/{$columnTwoWidth})*10)" stepKey="columnRatio"/>
533533
<assertEquals stepKey="assertRatioIsCorrect">
534-
<expectedResult type="float">1.5</expectedResult>
534+
<expectedResult type="int">15</expectedResult>
535535
<actualResult type="variable">columnRatio</actualResult>
536536
</assertEquals>
537537
<executeJS function="return Math.round({$columnOneWidth}/{$columnThreeWidth})" stepKey="columnRatio2"/>
@@ -548,9 +548,9 @@
548548
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnX('1')}}').clientWidth" stepKey="columnOneWidth2"/>
549549
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnX('2')}}').clientWidth" stepKey="columnTwoWidth2"/>
550550
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnX('3')}}').clientWidth" stepKey="columnThreeWidth2"/>
551-
<executeJS function="return Math.round({$columnOneWidth2}/{$columnTwoWidth2}*10)/10" stepKey="columnRatio3"/>
551+
<executeJS function="return Math.round(({$columnOneWidth2}/{$columnTwoWidth2})*10)" stepKey="columnRatio3"/>
552552
<assertEquals stepKey="assertRatioIsCorrect3">
553-
<expectedResult type="float">1.5</expectedResult>
553+
<expectedResult type="int">15</expectedResult>
554554
<actualResult type="variable">columnRatio3</actualResult>
555555
</assertEquals>
556556
<executeJS function="return Math.round({$columnOneWidth2}/{$columnThreeWidth2})" stepKey="columnRatio4"/>
@@ -568,9 +568,9 @@
568568
<executeJS function="return document.querySelector('{{ColumnOnFrontend.columnX('1')}}').clientWidth" stepKey="columnOneWidthFrontend"/>
569569
<executeJS function="return document.querySelector('{{ColumnOnFrontend.columnX('2')}}').clientWidth" stepKey="columnTwoWidthFrontend"/>
570570
<executeJS function="return document.querySelector('{{ColumnOnFrontend.columnX('3')}}').clientWidth" stepKey="columnThreeWidthFrontend"/>
571-
<executeJS function="return Math.round({$columnOneWidthFrontend}/{$columnTwoWidthFrontend}*10)/10" stepKey="columnRatioFrontend"/>
571+
<executeJS function="return Math.round(({$columnOneWidthFrontend}/{$columnTwoWidthFrontend})*10)" stepKey="columnRatioFrontend"/>
572572
<assertEquals stepKey="assertFrontendRatioIsCorrect">
573-
<expectedResult type="int">1.5</expectedResult>
573+
<expectedResult type="int">15</expectedResult>
574574
<actualResult type="variable">columnRatioFrontend</actualResult>
575575
</assertEquals>
576576
<executeJS function="return Math.round({$columnOneWidthFrontend}/{$columnThreeWidthFrontend})" stepKey="columnRatioFrontend2"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2210,6 +2210,9 @@
22102210
<group value="pagebuilder-row"/>
22112211
<group value="pagebuilder-rowBackground"/>
22122212
<group value="pagebuilder-video-background"/>
2213+
<skip>
2214+
<issueId value="MC-31468"/>
2215+
</skip>
22132216
</annotations>
22142217
<before>
22152218
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>

0 commit comments

Comments
 (0)