Skip to content

Commit 0182466

Browse files
committed
PB-179: Product Content Type Inner Contents Should Not Align Based On Alignment Configuration
- add descriptive param name - add comments
1 parent b2e2995 commit 0182466

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection/ProductsOnStageSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<element name="notHidden" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products') and not(contains(@class,'placeholder'))])[{{indexOfProductGroup}}]//parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]"/>
1515
<element name="emptyProductsPlaceholder" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{indexOfProductGroup}}]//*[contains(@class,'pagebuilder-products-placeholder')]"/>
1616
<element name="product" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')]"/>
17-
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{arg1}} - 1]" parameterized="true"/>
17+
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{indexOfProductItem}} - 1]" parameterized="true"/>
1818
<element name="productByIndex" type="text" parameterized="true" selector="((//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>
1919
<element name="productImage" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]//img[@class='product-image-photo']"/>
2020
<element name="productImageCSS" type="text" selector=".pagebuilder-products div[data-appearance=grid] ol li.product-item img.product-image-photo"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection/ProductsOnStorefrontSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<element name="hidden" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}][contains(@style, 'display: none')]"/>
1414
<element name="notHidden" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}][not(contains(@style, 'display: none'))]"/>
1515
<element name="product" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')]"/>
16-
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{arg1}} - 1]" parameterized="true"/>
16+
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{indexOfProductItem}} - 1]" parameterized="true"/>
1717
<element name="productsInCarouselNotClonedBySlick" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')]"/>
1818
<element name="productByIndex" type="text" parameterized="true" selector="((//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>
1919
<element name="productInCarouselNotClonedBySlickByIndex" type="text" parameterized="true" selector="((//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsGridTest/ProductsUpdateAdvancedConfigurationValuesTest.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@
143143
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
144144
<argument name="index" value="1"/>
145145
</actionGroup>
146+
<!-- Validate Product Item Inner Contents Stay Aligned Left -->
147+
<comment userInput="Validate Product Item Inner Contents Stay Aligned Left" stepKey="commentValidateStageContentsAlignedLeft"/>
146148
<executeJS function="return window.getComputedStyle({{ProductsOnStage.productJS('1')}}).textAlign" stepKey="grabComputedTextAlign"/>
147149
<assertEquals stepKey="assertComputedTextAlign">
148150
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyLeft.value}}</expectedResult>
@@ -194,6 +196,8 @@
194196
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
195197
<argument name="index" value="1"/>
196198
</actionGroup>
199+
<!-- Validate Product Item Inner Contents Stay Aligned Left Storefront -->
200+
<comment userInput="Validate Product Item Inner Contents Stay Aligned Left Storefront" stepKey="commentValidateStorefrontContentsAlignedLeft"/>
197201
<executeJS function="return window.getComputedStyle({{ProductsOnStorefront.productJS('1')}}).textAlign" stepKey="grabComputedTextAlignStorefront"/>
198202
<assertEquals stepKey="assertComputedTextAlignStorefront">
199203
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyLeft.value}}</expectedResult>

0 commit comments

Comments
 (0)