Skip to content

Commit b2e2995

Browse files
committed
PB-179: Product Content Type Inner Contents Should Not Align Based On Alignment Configuration
- add test to verify stage and storefront on existing test
1 parent 6a9cd9f commit b2e2995

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection/ProductsOnStageSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<element name="notHidden" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products') and not(contains(@class,'placeholder'))])[{{indexOfProductGroup}}]//parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]"/>
1515
<element name="emptyProductsPlaceholder" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{indexOfProductGroup}}]//*[contains(@class,'pagebuilder-products-placeholder')]"/>
1616
<element name="product" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')]"/>
17+
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{arg1}} - 1]" parameterized="true"/>
1718
<element name="productByIndex" type="text" parameterized="true" selector="((//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>
1819
<element name="productImage" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'grid')]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]//img[@class='product-image-photo']"/>
1920
<element name="productImageCSS" type="text" selector=".pagebuilder-products div[data-appearance=grid] ol li.product-item img.product-image-photo"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection/ProductsOnStorefrontSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<element name="hidden" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}][contains(@style, 'display: none')]"/>
1414
<element name="notHidden" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}][not(contains(@style, 'display: none'))]"/>
1515
<element name="product" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')]"/>
16+
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{arg1}} - 1]" parameterized="true"/>
1617
<element name="productsInCarouselNotClonedBySlick" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')]"/>
1718
<element name="productByIndex" type="text" parameterized="true" selector="((//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>
1819
<element name="productInCarouselNotClonedBySlickByIndex" type="text" parameterized="true" selector="((//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsGridTest/ProductsUpdateAdvancedConfigurationValuesTest.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@
143143
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
144144
<argument name="index" value="1"/>
145145
</actionGroup>
146+
<executeJS function="return window.getComputedStyle({{ProductsOnStage.productJS('1')}}).textAlign" stepKey="grabComputedTextAlign"/>
147+
<assertEquals stepKey="assertComputedTextAlign">
148+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyLeft.value}}</expectedResult>
149+
<actualResult type="variable">grabComputedTextAlign</actualResult>
150+
</assertEquals>
146151
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage3">
147152
<argument name="contentType" value="PageBuilderProductsContentType"/>
148153
</actionGroup>
@@ -189,5 +194,10 @@
189194
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
190195
<argument name="index" value="1"/>
191196
</actionGroup>
197+
<executeJS function="return window.getComputedStyle({{ProductsOnStorefront.productJS('1')}}).textAlign" stepKey="grabComputedTextAlignStorefront"/>
198+
<assertEquals stepKey="assertComputedTextAlignStorefront">
199+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyLeft.value}}</expectedResult>
200+
<actualResult type="variable">grabComputedTextAlignStorefront</actualResult>
201+
</assertEquals>
192202
</test>
193203
</tests>

0 commit comments

Comments
 (0)