MAGECLOUD-2895: The var/log/install_upgrade.log is useless without dividers and timestamps

Author: BaDos

src/Process/Deploy/InstallUpdate/Install/Setup.php

@@ -112,11 +112,13 @@ public function execute()
         }
 
         try {
-            $this->shell->execute("echo 'Installation time: '$(date)");
+            $installUpgradeLog = $this->fileList->getInstallUpgradeLog();
+
+            $this->shell->execute('echo \'Installation time: \'$(date) | tee -a ' . $installUpgradeLog);
             $this->shell->execute(sprintf(
                 '/bin/bash -c "set -o pipefail; %s | tee -a %s"',
                 escapeshellcmd($command),
-                $this->fileList->getInstallUpgradeLog()
+                $installUpgradeLog
             ));
         } catch (ShellException $exception) {
             throw new ProcessException($exception->getMessage(), $exception->getCode(), $exception);

src/Process/Deploy/InstallUpdate/Update/Setup.php

@@ -93,14 +93,15 @@ public function execute()
 
         try {
             $verbosityLevel = $this->stageConfig->get(DeployInterface::VAR_VERBOSE_COMMANDS);
+            $installUpgradeLog = $this->fileList->getInstallUpgradeLog();
 
             $this->logger->info('Running setup upgrade.');
 
-            $this->shell->execute("echo 'Upgrading time: '$(date)");
+            $this->shell->execute('echo \'Updating time: \'$(date) | tee -a ' . $installUpgradeLog);
             $this->shell->execute(sprintf(
                 '/bin/bash -c "set -o pipefail; %s | tee -a %s"',
                 'php ./bin/magento setup:upgrade --keep-generated --ansi --no-interaction ' . $verbosityLevel,
-                $this->fileList->getInstallUpgradeLog()
+                $installUpgradeLog
             ));
         } catch (\RuntimeException $exception) {
             //Rollback required by database

src/Test/Unit/Process/Deploy/InstallUpdate/Install/SetupTest.php

@@ -187,7 +187,7 @@ public function testExecute(
         $this->shellMock->expects($this->exactly(2))
             ->method('execute')
             ->withConsecutive(
-                ["echo 'Installation time: '$(date)"],
+                ['echo \'Installation time: \'$(date) | tee -a ' . $installUpgradeLog],
                 ['/bin/bash -c "set -o pipefail;'
                 . ' php ./bin/magento setup:install -n --session-save=db --cleanup-database --currency=\'USD\''
                 . ' --base-url=\'http://unsecure.url\' --base-url-secure=\'https://secure.url\' --language=\'fr_FR\''

src/Test/Unit/Process/Deploy/InstallUpdate/Update/SetupTest.php

@@ -108,7 +108,7 @@ public function testExecute()
         $this->shellMock->expects($this->exactly(2))
             ->method('execute')
             ->withConsecutive(
-                ["echo 'Upgrading time: '$(date)"],
+                ['echo \'Updating time: \'$(date) | tee -a ' . $installUpgradeLog],
                 ['/bin/bash -c "set -o pipefail; php ./bin/magento setup:upgrade '
                 . '--keep-generated --ansi --no-interaction -v | tee -a '
                 . $installUpgradeLog . '"']