MAGECLOUD-2895: The var/log/install_upgrade.log is useless without dividers and timestamps

Author: BaDos

src/Process/Deploy/InstallUpdate/Install/Setup.php

@@ -112,6 +112,7 @@ public function execute()
         }
 
         try {
+            $this->shell->execute("echo 'Installation time: '$(date)");
             $this->shell->execute(sprintf(
                 '/bin/bash -c "set -o pipefail; %s | tee -a %s"',
                 escapeshellcmd($command),

src/Process/Deploy/InstallUpdate/Update/Setup.php

@@ -96,6 +96,7 @@ public function execute()
 
             $this->logger->info('Running setup upgrade.');
 
+            $this->shell->execute("echo 'Upgrading time: '$(date)");
             $this->shell->execute(sprintf(
                 '/bin/bash -c "set -o pipefail; %s | tee -a %s"',
                 'php ./bin/magento setup:upgrade --keep-generated --ansi --no-interaction ' . $verbosityLevel,

src/Test/Unit/Process/Deploy/InstallUpdate/Install/SetupTest.php

@@ -184,18 +184,19 @@ public function testExecute(
                 . ' --admin-firstname=\'' . $adminFirstnameExpected . '\' --admin-lastname=\'' . $adminLastnameExpected
                 . '\' --admin-email=\'' . $adminEmail . '\' --admin-password=\'' . $adminPasswordExpected . '\''
             : '';
-        $this->shellMock->expects($this->once())
+        $this->shellMock->expects($this->exactly(2))
             ->method('execute')
-            ->with(
-                '/bin/bash -c "set -o pipefail;'
+            ->withConsecutive(
+                ["echo 'Installation time: '$(date)"],
+                ['/bin/bash -c "set -o pipefail;'
                 . ' php ./bin/magento setup:install -n --session-save=db --cleanup-database --currency=\'USD\''
                 . ' --base-url=\'http://unsecure.url\' --base-url-secure=\'https://secure.url\' --language=\'fr_FR\''
                 . ' --timezone=America/Los_Angeles --db-host=\'localhost\' --db-name=\'magento\' --db-user=\'user\''
                 . ' --backend-frontname=\'' . $adminUrlExpected . '\''
                 . $adminCredential
                 . ' --use-secure-admin=1 --ansi --no-interaction'
                 . ' --db-password=\'password\' -v'
-                . ' | tee -a ' . $installUpgradeLog . '"'
+                . ' | tee -a ' . $installUpgradeLog . '"']
             );
 
         $this->process->execute();

src/Test/Unit/Process/Deploy/InstallUpdate/Update/SetupTest.php

@@ -105,12 +105,13 @@ public function testExecute()
         $this->flagManagerMock->expects($this->exactly(2))
             ->method('delete')
             ->with(FlagManager::FLAG_REGENERATE);
-        $this->shellMock->expects($this->once())
+        $this->shellMock->expects($this->exactly(2))
             ->method('execute')
-            ->with(
-                '/bin/bash -c "set -o pipefail; php ./bin/magento setup:upgrade '
+            ->withConsecutive(
+                ["echo 'Upgrading time: '$(date)"],
+                ['/bin/bash -c "set -o pipefail; php ./bin/magento setup:upgrade '
                 . '--keep-generated --ansi --no-interaction -v | tee -a '
-                . $installUpgradeLog . '"'
+                . $installUpgradeLog . '"']
             );
         $this->loggerMock->expects($this->once())
             ->method('info')