-
Notifications
You must be signed in to change notification settings - Fork 139
Add Azure test for User Access Administrator #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor changes from a quick proofread.
@Oppedijk This is a good test to include. Thanks for the PR. In addition to the formatting details above, there are some changes we need to make to best align with the existing tests.
Invoke-AzRestMethod -Path "/providers/Microsoft.Authorization/roleDefinitions?api-version=2022-04-01&`$filter=roleName+eq+'User Access Administrator'" Thanks! |
I will take a look, however that will complicate things, as it will be harder to detect the permission denied, as this will list all roles on all levels? I will do some testing and let you know. |
@merill can you take a look at the current setup, I've used the Get-AzRoleAssignment, as I need to look up the assigned permissions at the root scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't resolve the conversations related to my previous review, but it looks like those issues are fixed.
@Oppedijk I had some time and was able to find the right filter and made the switch. Can you please check and verify? |
Thanks @Oppedijk for adding this new test and @moorereason + @SamErde for helping improve! |
No description provided.