Skip to content

Commit e1d3c16

Browse files
committed
improved magic getter/setter analysis
1 parent 6c6e8ff commit e1d3c16

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Reflection/Varien/Object/MagicMethodReflection.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public function getDocComment(): ?string
6969

7070
public function isDeprecated(): \PHPStan\TrinaryLogic
7171
{
72-
return \PHPStan\TrinaryLogic::createNo();
72+
return \PHPStan\TrinaryLogic::createMaybe();
7373
}
7474

7575
public function getDeprecatedDescription(): ?string
@@ -84,7 +84,7 @@ public function isFinal(): \PHPStan\TrinaryLogic
8484

8585
public function isInternal(): \PHPStan\TrinaryLogic
8686
{
87-
return \PHPStan\TrinaryLogic::createNo();
87+
return \PHPStan\TrinaryLogic::createMaybe();
8888
}
8989

9090
public function getThrowType(): ?\PHPStan\Type\Type
@@ -94,6 +94,6 @@ public function getThrowType(): ?\PHPStan\Type\Type
9494

9595
public function hasSideEffects(): \PHPStan\TrinaryLogic
9696
{
97-
return \PHPStan\TrinaryLogic::createNo();
97+
return \PHPStan\TrinaryLogic::createMaybe();
9898
}
9999
}

src/Reflection/Varien/Object/MagicMethodsReflectionExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ final class MagicMethodsReflectionExtension implements MethodsClassReflectionExt
1414
public function hasMethod(ClassReflection $classReflection, string $methodName): bool
1515
{
1616
$magentoMagicMethods = ['get', 'set', 'uns', 'has'];
17-
return $classReflection->isSubclassOf(Varien_Object::class)
17+
return ($classReflection->isSubclassOf(Varien_Object::class) || $classReflection->getName() === Varien_Object::class)
1818
&& \in_array(substr($methodName, 0, 3), $magentoMagicMethods, true);
1919
}
2020

0 commit comments

Comments
 (0)