implemented changes to make extension compatible with phpstan v0.12, updated README

Author: ma4nn

README.md

@@ -1,8 +1,8 @@
-# phpstan-magento1 extension
+# PHPStan Extension for Magento 1
 
 Extension for [PHPStan](https://github.com/phpstan/phpstan) to allow analysis of Magento 1 code.
 
-Currently it assumes Magento is installed in the public/ directory of the project root. Further work is needed in phpstan itself to allow more intellegence for extensions to be more customised whilst working with both phpstan/phpstan and phpstan/phpstan-shim.
+Currently it assumes Magento is installed in the `htdocs/` directory of the project root. Further work is needed in phpstan itself to allow more intellegence for extensions to be more customised whilst working with both phpstan/phpstan and phpstan/phpstan-shim.
 
 ## Usage
 
@@ -12,23 +12,15 @@ Make sure it has
 
 ```neon
 includes:
-    - vendor/inviqa/phpstan-magento1/extension.neon
+    - vendor/vianetz/phpstan-magento1/extension.neon
 ```
 
-Whilst this extension depends on phpstan/phpstan, it can also depend on phpstan/phpstan-shim, which decouples its dependencies from the project's own use of them.
-
-With coupled dependencies:
+Then run
 
 ```bash
 composer require inviqa/phpstan-magento1 phpstan/phpstan
 ```
 
-With uncoupled phar package:
-
-```bash
-composer require inviqa/phpstan-magento1 phpstan/phpstan-shim
-```
-
 ## Alternative Magento path
 
 By default this extension assumes the Magento directory is `%currentWorkingDirectory%/htdocs`.
@@ -39,9 +31,6 @@ Add to the project's phpstan.neon:
 parameters:
     paths:
         - %currentWorkingDirectory%/path/to/magento/app/code/local
-    excludes_analyse:
-        - %currentWorkingDirectory%/path/to/magento/app/code/local/*/*/data/*
-        - %currentWorkingDirectory%/path/to/magento/app/code/local/*/*/sql/*
     autoload_files:
         - %currentWorkingDirectory%/path/to/magento/app/Mage.php
 ```

composer.json

@@ -3,7 +3,7 @@
     "description": "Extension for PHPStan to allow analysis of Magento 1 code.",
     "type": "library",
     "require": {
-        "phpstan/phpstan": "^0.11",
+        "phpstan/phpstan": "^0.11|^0.12",
         "php": ">= 7.2",
         "nikic/php-parser": "^4.4"
     },

extension.neon

@@ -1,6 +1,5 @@
 parameters:
-    vendor_path: %currentWorkingDirectory%/vendor
-    bootstrap: %vendor_path%/vianetz/phpstan-magento1/phpstan-bootstrap.php
+    bootstrap: %currentWorkingDirectory%/vendor/vianetz/phpstan-magento1/phpstan-bootstrap.php
     excludes_analyse:
         - */app/code/local/*/*/data/*
         - */app/code/local/*/*/sql/*

phpstan-bootstrap.php

@@ -10,3 +10,5 @@
 // workaround Magento's use of date phpdoc typehint for string type
 // better would be to implement the typehint to make it appear string type
 class date {}
+
+Mage::app();

src/Reflection/Varien/Object/MagicMethodReflection.php

@@ -61,4 +61,39 @@ public function getVariants(): array
             new TrivialParametersAcceptor(),
         ];
     }
+
+    public function getDocComment(): ?string
+    {
+        return null;
+    }
+
+    public function isDeprecated(): \PHPStan\TrinaryLogic
+    {
+        return \PHPStan\TrinaryLogic::createNo();
+    }
+
+    public function getDeprecatedDescription(): ?string
+    {
+        return null;
+    }
+
+    public function isFinal(): \PHPStan\TrinaryLogic
+    {
+        return \PHPStan\TrinaryLogic::createNo();
+    }
+
+    public function isInternal(): \PHPStan\TrinaryLogic
+    {
+        return \PHPStan\TrinaryLogic::createNo();
+    }
+
+    public function getThrowType(): ?\PHPStan\Type\Type
+    {
+        return null;
+    }
+
+    public function hasSideEffects(): \PHPStan\TrinaryLogic
+    {
+        return \PHPStan\TrinaryLogic::createNo();
+    }
 }