Skip to content

Commit 271ec5f

Browse files
committed
Rename fixtures
1 parent 869aa7a commit 271ec5f

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

tests/pytest/test_render_data_frame_tbl_data.py

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ def polars_series_to_narwhals(ser: pl.Series) -> nw.Series:
7474

7575

7676
@pytest.fixture(params=params_frames, scope="function")
77-
def df(request: pytest.FixtureRequest) -> DataFrameLike:
77+
def df_f(request: pytest.FixtureRequest) -> DataFrameLike:
7878
return request.param(DATA)
7979

8080

8181
@pytest.fixture(params=params_frames, scope="function")
82-
def small_df(request: pytest.FixtureRequest) -> DataFrameLike:
82+
def small_df_f(request: pytest.FixtureRequest) -> DataFrameLike:
8383
return request.param({"x": [1, 2], "y": [3, 4]})
8484

8585

@@ -154,13 +154,13 @@ def test_serialize_dtype(
154154
assert serialize_dtype(ser)["type"] == res_type
155155

156156

157-
def test_serialize_frame(df: DataFrameLike):
157+
def test_serialize_frame(df_f: DataFrameLike):
158158
# TODO: pandas converts datetime entries to int, but Polars
159159
# preserves the datetime object.
160-
if isinstance(df, pl.DataFrame):
160+
if isinstance(df_f, pl.DataFrame):
161161
pytest.xfail()
162162

163-
res = serialize_frame(df)
163+
res = serialize_frame(df_f)
164164
assert res == {
165165
"columns": ["num", "chr", "cat", "dt", "struct", "arr", "object"],
166166
"index": [0, 1],
@@ -180,42 +180,42 @@ def test_serialize_frame(df: DataFrameLike):
180180
}
181181

182182

183-
def test_subset_frame(df: DataFrameLike):
183+
def test_subset_frame(df_f: DataFrameLike):
184184
# TODO: this assumes subset_frame doesn't reset index
185-
res = subset_frame(df, rows=[1], cols=["chr", "num"])
185+
res = subset_frame(df_f, rows=[1], cols=["chr", "num"])
186186
dst = {"chr": ["b"], "num": [2]}
187187

188188
assert_frame_equal2(res, dst)
189189

190190

191-
def test_get_frame_cell(df: DataFrameLike):
192-
assert get_frame_cell(df, 1, 1) == "b"
191+
def test_get_frame_cell(df_f: DataFrameLike):
192+
assert get_frame_cell(df_f, 1, 1) == "b"
193193

194194

195-
def test_copy_frame(df: DataFrameLike):
196-
new_df = copy_frame(df)
195+
def test_copy_frame(df_f: DataFrameLike):
196+
new_df = copy_frame(df_f)
197197

198-
assert new_df is not df
198+
assert new_df is not df_f
199199

200200

201-
def test_subset_frame_rows_single(small_df: DataFrameLike):
202-
res = subset_frame(small_df, rows=[1])
201+
def test_subset_frame_rows_single(small_df_f: DataFrameLike):
202+
res = subset_frame(small_df_f, rows=[1])
203203

204204
assert_frame_equal2(
205205
res,
206206
{"x": [2], "y": [4]},
207207
)
208208

209209

210-
def test_subset_frame_cols_single(small_df: DataFrameLike):
210+
def test_subset_frame_cols_single(small_df_f: DataFrameLike):
211211
# TODO: include test of polars
212-
res = subset_frame(small_df, cols=["y"])
212+
res = subset_frame(small_df_f, cols=["y"])
213213

214214
assert_frame_equal2(
215215
res,
216216
{"y": [3, 4]},
217217
)
218218

219219

220-
def test_shape(small_df: DataFrameLike):
221-
assert frame_shape(small_df) == (2, 2)
220+
def test_shape(small_df_f: DataFrameLike):
221+
assert frame_shape(small_df_f) == (2, 2)

0 commit comments

Comments
 (0)