Fix typing issues

Author: schloerke

shiny/render/_data_frame_utils/_html.py

@@ -9,6 +9,8 @@
 from ._types import CellHtml, ReprHtml, SeriesLike
 
 if TYPE_CHECKING:
+    import narwhals.stable.v1 as nw
+
     from ...session import Session
 
 
@@ -41,8 +43,11 @@ def maybe_as_cell_html(
     return cast(Jsonifiable, x)
 
 
-def col_contains_shiny_html(col: SeriesLike) -> bool:
-    return any(is_shiny_html(val) for _, val in enumerate(col))
+def col_contains_shiny_html(col: SeriesLike | nw.Series) -> bool:
+    for val in col:
+        if is_shiny_html(val):
+            return True
+    return False
 
 
 # TODO-barret-test; Add test to assert the union type of `TagNode` contains `str` and (HTML | Tagifiable | MetadataNode | ReprHtml). Until a `is tag renderable` method is available in htmltools, we need to check for these types manually and must stay in sync with the `TagNode` union type.

tests/pytest/test_render_data_frame_tbl_data.py

@@ -51,12 +51,19 @@ class D:
     "object": [C(1), D(2)],
 }
 
+
+def polars_df_to_narwhals(df: dict[str, Any]) -> nw.DataFrame[pl.DataFrame]:
+    return nw.from_native(pl.DataFrame(df), eager_only=True)
+
+
+def polars_series_to_narwhals(ser: pl.Series) -> nw.Series:
+    return nw.from_native(ser, series_only=True, strict=True)
+
+
 params_frames = [
     pytest.param(pd.DataFrame, id="pandas"),
     pytest.param(pl.DataFrame, id="polars"),
-    pytest.param(
-        lambda d: nw.from_native(pl.DataFrame(d), eager_only=True), id="narwhals"
-    ),
+    pytest.param(polars_df_to_narwhals, id="narwhals"),
 ]
 
 DataFrameLike: TypeAlias = Union[pd.DataFrame, pl.DataFrame]
@@ -99,7 +106,7 @@ def assert_frame_equal(
 
 def assert_frame_equal2(
     src: pd.DataFrame | pl.DataFrame,
-    target_dict: dict,
+    target_dict: dict[str, Any],
     use_index: bool = False,
 ):
     src = nw.to_native(src, strict=False)
@@ -142,12 +149,8 @@ def test_serialize_dtype(
     res_type: str,
 ):
     if isinstance(ser, pl.Series):
-        assert (
-            serialize_dtype(nw.from_native(ser, eager_only=True, allow_series=True))[
-                "type"
-            ]
-            == res_type
-        )
+        nw_ser = polars_series_to_narwhals(ser)
+        assert serialize_dtype(nw_ser)["type"] == res_type
     assert serialize_dtype(ser)["type"] == res_type