Skip to content

analyzeCss.js: lazy load analyze-css module via await import() #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

analyzeCss.js: lazy load analyze-css module via await import() #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9eed8b
analyzeCss.js: lazy load analyze-css module via await import()
macbre Jun 14, 2022
d8174d0
eslint: allow dynamicImport syntax
macbre Jun 14, 2022
6ac7c04
Merge branch 'devel' into esm/analyze-css
macbre Nov 21, 2022
3547c97
Merge branch 'devel' into esm/analyze-css
macbre Jul 31, 2023
91af12f
Merge branch 'devel' into esm/analyze-css
macbre Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ rules:
- allowEmptyCatch: true
no-prototype-builtins: 'off'
"node/no-extraneous-require": 'off'
"node/no-unsupported-features/es-syntax": 'error'
"node/no-unsupported-features/es-syntax": ['error', {'ignores': ['dynamicImport']}]
10 changes: 5 additions & 5 deletions modules/analyzeCss/analyzeCss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,6 @@ module.exports = function (phantomas) {
return;
}

// load analyze-css module
// https://www.npmjs.com/package/analyze-css
const analyzer = require("analyze-css");
phantomas.log("Using version %s", analyzer.version);

phantomas.setMetric("cssParsingErrors"); // @desc number of CSS files (or embeded CSS) that failed to be parse by analyze-css @optional
phantomas.setMetric("cssInlineStyles"); // @desc number of inline styles @optional

Expand Down Expand Up @@ -92,6 +87,11 @@ module.exports = function (phantomas) {
}
**/

// load analyze-css module
// https://www.npmjs.com/package/analyze-css
const analyzer = (await import("analyze-css")).default;
phantomas.log("Using version %s", analyzer.version);

// https://www.npmjs.com/package/analyze-css#commonjs-module
var options = {};
let results;
Expand Down