src/redis/mcaptcha_redis: Allow mcaptcha_cache redis module to not be first in module list #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please bear with me, I wouldn't call myself much of a Rust programmer)
In NGIpkgs, we have mCaptcha packaged and verify its functionality with some VM tests. We were having issues with mCaptcha sometimes incorrectly deciding that the Redis server it's talking to doesn't have the
mcaptcha_cachemodule loaded:I debugged this in ngi-nix/ngipkgs#1464 down to this code, where only the first received module entry is checked. But the order of the module listings which this code gets from Redis doesn't always seem to have
mcaptcha_cacheat the first position. On some runs, it's:Other times, it's:
This PR drops the
s.first()call, and just checks the entire list for themcaptcha_cachemodule.