Skip to content

GC0308: add explicit constructor to enable custom camera configs #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhaberler
Copy link

the way this was coded made the camera_config_t* config; member variable useless, as it is never set or used.

with this change:

  • the constructor can optionally accept a pointer to a custom camera_config_t struct
  • when using the default camera_config, it can be accessed and changed via the config member variable or by passing a custom config via begin
  • the used config struct can always be accessed via the config member.

Here is a demo for the CoreS3 which reads and decodes a QRcode via the builtin camera, and connects to WiFi if the qrcode was a Wifi URI:

https://github.com/mhaberler/cores3-read-qrcode.git

this uses the patch attached to customize the camera config (resolution, grayscale):

the way this was coded made the camera_config_t* config; member variable
useless, as it is never set or used.

with this change:

- the constructor can optionally accept a pointer to a custom camera_config_t
  struct
- when using the default camera_config, it can be accessed and changed
  via the config member variable or by passing a custom config via begin
- the used config struct can always be accessed via the config member.
@mhaberler
Copy link
Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant