Add website restriction compatibility (fixes issue #1) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…appmanifest_index_json. Add webrestrictions.xml so that action is always accessible even with website restrictions enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1 where manifest.json doesn't load properly when website restrictions are enabled.
Because the website restrictions module matches webrestrictions.xml entries based on $request->getFullActionName(), the route name needs to be set in Router.php so it produces webappmanifest_index_json (it was previously producing _index_json).
The entry in webrestrictions.xml indicates that the manifest file should be available when restrictions are enabled.