Skip to content

feat: use item-key as beforeMap key in diffArrayLepus #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2025
+280 −107
Merged

feat: use item-key as beforeMap key in diffArrayLepus #1598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
491563b
feat: use item key as beforeMap key in diffArrayLepus
gaoachao Aug 25, 2025
37667f3
chore: add test and changeset
gaoachao Oct 30, 2025
10bf8fb
Update .changeset/clear-numbers-call.md
gaoachao Nov 4, 2025
32e8ce2
chore: rename
gaoachao Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .changeset/clear-numbers-call.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
"@lynx-js/react": patch
---

During hydration, replace update with insert + remove for same-type `<list-item />` with different `item-key` so the Lynx Engine detects changes.

```html
Hydrate List B into List A:

List A:
<list>
<list-item item-key="a">hello</list-item>
<list-item item-key="a">world</list-item>
</list>

List B:
<list>
<list-item item-key="a1">hello</list-item>
<list-item item-key="a2">world</list-item>
</list>
```

Previously this case was hydrated as an update; it is now emitted as insert + remove to ensure SDK detection.
Loading
Loading