Add Async Support

[theGowda]

Added async support. Uses asyncio.open_connection which provied StreamReader and Writer

[theGowda]

Sorry about the previous PR #302 it was wrong

[theGowda]

should pass all checks now.
Need to add tests for all async part

[theGowda]

@luqasz any thoughts on this?

[luqasz]

@theGowda Do you want to add tests ?

[theGowda]

@theGowda Do you want to add tests ?

I have never written async tests. Basically have to copy everything with async await.
I'll create another folder inside test for async tests

[luqasz]

@theGowda you can run tests locally.

[theGowda]

@theGowda you can run tests locally.

Ya the integration tests passed.
I am updating the unit tests

[luqasz]

@theGowda you can run tests locally.

Ya the integration tests passed. I am updating the unit tests

https://github.com/luqasz/librouteros/actions/runs/12126034808/job/33859566156

[theGowda]

@theGowda you can run tests locally.

Ya the integration tests passed. I am updating the unit tests

https://github.com/luqasz/librouteros/actions/runs/12126034808/job/33859566156

I had to install pytest-asyncio as dev dependency for the async tests. Is that causing it? Because tests seem to pass locally.
I'll check

[luqasz]

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

Everything is written in actions output.

[theGowda]

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

Everything is written in actions output.

i'll complete the unit tests and push a commit

[luqasz]

Async integration tests are failing. Looks like it can't connect. You can download docker images with routeros vms.

[theGowda]

Async integration tests are failing. Looks like it can't connect. You can download docker images with routeros vms.

But I dont understand why it is failing. I ran integration tests locally using qcow2 images as suggested in the readme file.
Worked fine.

I'll check with your images

[luqasz]

Maybe increase timeout in async_connect()

[theGowda]

Maybe increase timeout in async_connect()

changed it to 60 for now in tests

[theGowda]

@luqasz can you please re-run the failed tests. it will pass.

[luqasz]

/__w/librouteros/librouteros/.venv/lib/python3.8/site-packages/pytest_asyncio/plugin.py:208: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"

Pytest throws this warning both ni unit and integration tests.

[theGowda]

/__w/librouteros/librouteros/.venv/lib/python3.8/site-packages/pytest_asyncio/plugin.py:208: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"

Pytest throws this warning both ni unit and integration tests.

That's fine. Just a warning. Its about the asyncio loop. I don't think it'll affect the functioning in our case

[luqasz]

OK. Final review.

[luqasz]

@theGowda can you please move integration/async into `integration ? IMO it's unnecessary to duplicate fixture code. Adding async tests into existing files will be fine.

[theGowda]

@theGowda can you please move integration/async into `integration ? IMO it's unnecessary to duplicate fixture code. Adding async tests into existing files will be fine.

Okay. I'll move the tests

[theGowda]

@luqasz i think you sould stop the test for python 3.12. its been running for 10mins now

[luqasz]

Seems that on 3.12 tests timeout but only for routeros 6.33.3. Does those run locally ?

[theGowda]

Seems that on 3.12 tests timeout but only for routeros 6.33.3. Does those run locally ?

Yes. Github action succeeded in my fork.