feat: Implement Zodiac Module for CoW Swap Trading with Token Allowlist #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CI workflow to install all project dependencies via 'ape pm install' Previously only installed solady dependency
Add Gnosis Guild Zodiac Module dependencies to contracts/dependencies Create initial AgentTradingModule contract Update remappings in ape-config.yaml for new dependencies Temporarily include Zodiac contract dependencies locally to resolve compilation issues
Replace remapping-based imports with explicit relative paths Add missing Zodiac guard contracts and interfaces Add OpenZeppelin contracts for IERC165 Update ape-config.yaml remapping configuration
Add constructor and setUp initializer with required dependencies Implement initial setOrderTradeable function with core validations Remove abstract template in favor of concrete implementation
Remove trader-build and trader-test jobs Add Foundry-based contract testing pipeline Simplify workflow to lint/build/test smart contracts Keep Python linting for cow-trader
Add basic test setup with: - Base test contract with common setup - Constants contract for addresses - Utils contract for test helpers - Initial TokenAllowlist unit tests
TradingModule now focuses on order validation and execution CoWSwapGuard enforces CoW Swap specific rules: - Target contract must be GPv2Settlement - Tokens must be CoW DAO allowed - Function must be setPreSignature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Zodiac Module for managing automated trading on CoW Swap with safety controls.
Key Changes
TradingModulewith order validation capabilitiesisOrderAllowedfunction to check if token pairs are allowed to tradeImplementation Details
TradingModule:
setPreSignaturecalls through Safe avatarCoWSwapGuardfor trade validationCoWSwapGuard enforces:
GPv2SettlementsetPreSignaturefunction calls allowedTechnical Notes
GPv2Orderlibrary used for order validationTradingModuleinherits from Zodiac's Module andGuardablecontracts