Skip to content

feat(ss): update ss version and add yarnrc.yml to updater script #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(ss): update ss version and add yarnrc.yml to updater script #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f553be
fix(cra): update ss and updated script
germainruget Apr 30, 2024
a315114
fix(cra): update cra version
germainruget Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .yarn/install-state.gz
View file
Open in desktop
Binary file not shown.
19 changes: 19 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,25 @@ async function updateExtension() {
},
])
.then(async (answers) => {
await inquirer
.prompt([
{
type: "confirm",
name: "confirmYarnRC",
message:
"➤ You need to add nodeLinker: node-modules to your .yarnrc.yml file. Do you want to update it ? (the old one will be backed up)",
default: true,
},
])
.then(async (answers) => {
if (answers.confirmTsConfig) {
await backAndCopyFile(".yarnrc.yml");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible de faire un diff des fichiers dans cette fonction ?
Je me suis retrouvé hier avec des fichiers dupliqués identiques.
De plus il faudrait probablement incrémenter les sauvegardes si le fichier est déjà présent (.old, .old.1)

console.log(
chalk.green("➤ .yarnrc.yml file updated successfully !")
);
}
});

if (answers.confirmUpdate) {
const {
forcedDependencies,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-lumapps-extension",
"version": "1.4.0",
"version": "1.4.1-rc.2",
"description": "",
"author": "marketplace@lumapps.com",
"main": "index.js",
Expand Down
4 changes: 2 additions & 2 deletions template-backend-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "template-react-ts",
"version": "1.3.1",
"version": "1.4.1-rc.2",
"private": true,
"scripts": {
"build": "yarn start:shipping-server bundle",
Expand Down Expand Up @@ -49,7 +49,7 @@
},
"devDependencies": {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.2",
"@testing-library/user-event": "^14.5.2",
Expand Down
4 changes: 2 additions & 2 deletions template-empty-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "template-react-ts",
"version": "1.3.1",
"version": "1.4.1-rc.2",
"private": true,
"scripts": {
"build": "yarn start:shipping-server bundle",
Expand Down Expand Up @@ -49,7 +49,7 @@
},
"devDependencies": {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.2",
"@testing-library/user-event": "^14.5.2",
Expand Down
4 changes: 2 additions & 2 deletions template-search-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "template-react-ts",
"version": "1.3.1",
"version": "1.4.1-rc.2",
"private": true,
"scripts": {
"build": "yarn start:shipping-server bundle",
Expand Down Expand Up @@ -49,7 +49,7 @@
},
"devDependencies": {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.2",
"@testing-library/user-event": "^14.5.2",
Expand Down
4 changes: 2 additions & 2 deletions template-share-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "template-react-ts",
"version": "1.3.1",
"version": "1.4.1-rc.2",
"private": true,
"scripts": {
"build": "yarn start:shipping-server bundle",
Expand Down Expand Up @@ -49,7 +49,7 @@
},
"devDependencies": {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.2",
"@testing-library/user-event": "^14.5.2",
Expand Down
4 changes: 2 additions & 2 deletions template-widget-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "template-react-ts",
"version": "1.3.1",
"version": "1.4.1-rc.2",
"private": true,
"scripts": {
"build": "yarn start:shipping-server bundle",
Expand Down Expand Up @@ -49,7 +49,7 @@
},
"devDependencies": {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.2",
"@testing-library/user-event": "^14.5.2",
Expand Down
1 change: 1 addition & 0 deletions updateFiles/.yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodeLinker: node-modules
2 changes: 1 addition & 1 deletion updateFiles/dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
},
devDependencies: {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@types/react": "17.0.2",
"@types/react-dom": "17.0.2",
},
Expand Down
2 changes: 1 addition & 1 deletion updateFiles/updatePackages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
},
devDependencies: {
"@lumapps-extensions-playground/devenv": "1.27.0",
"@lumapps-extensions/shipping-server": "1.9.2",
"@lumapps-extensions/shipping-server": "1.9.3-rc.1",
"@types/react": "17.0.2",
"@types/react-dom": "17.0.2",
},
Expand Down