Skip to content

Fix console warnings on img overflow and popover margin styles #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −1
Open

Fix console warnings on img overflow and popover margin styles #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93ce319
fix(popover): fix popper warning on margin style from visually-hidden
gcornut Jul 10, 2025
483fa34
fix(thumbnail): fix console warning on img overflow style
gcornut Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- `Popover` & `Tooltip`: fix popper warning on margin style applied by class `.visually-hidden`.
- `Thumbnail`: fix console warning on img overflow style.

## [3.15.0][] - 2025-07-02

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/lumx-core/src/scss/components/thumbnail/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
// When using object-fit:cover + ratio 1/1, Chrome switches to pixelated downsizing algo
// https://stackoverflow.com/a/77059936
// The following prevent this so the image is correctly downsized using blurring effect
overflow-clip-margin: unset;
translate: 0 0 0.01px;

@supports not (aspect-ratio: 1 / 1) {
position: absolute;
Expand Down
5 changes: 5 additions & 0 deletions packages/lumx-core/src/scss/core/base/_helpers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@
clip: rect(0 0 0 0) !important;
border: 0 !important;
}

/** Need to remove the margin style on popper elements or else we get warnings in the console */
.lumx-popover.visually-hidden, .lumx-tooltip.visually-hidden {
margin: revert !important;
}
Loading